Merged
Conversation
0eda15b to
d37caed
Compare
keithamus
reviewed
Jan 6, 2025
Contributor
|
It looks as though there's a test failure - that perhaps should be changed with this change? |
Contributor
Author
The failing test is not because of or affected by this change as stated in my original comment (it also appears that quite a few tests use In the test of the check you run: it is |
keithamus
approved these changes
Jan 13, 2025
joshblack
approved these changes
Jan 13, 2025
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Jan 17, 2025
…#6559) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@github/relative-time-element](https://github.com/github/relative-time-element) | dependencies | patch | [`4.4.4` -> `4.4.5`](https://renovatebot.com/diffs/npm/@github%2frelative-time-element/4.4.4/4.4.5) | --- ### Release Notes <details> <summary>github/relative-time-element (@​github/relative-time-element)</summary> ### [`v4.4.5`](https://github.com/github/relative-time-element/releases/tag/v4.4.5) [Compare Source](github/relative-time-element@v4.4.4...v4.4.5) #### What's Changed - fix: wrap Intl.<>() calls in try/catch by [@​francinelucca](https://github.com/francinelucca) in github/relative-time-element#297 - get main branch green by [@​keithamus](https://github.com/keithamus) in github/relative-time-element#302 - Make `applyDuration` reversible by [@​leduyquang753](https://github.com/leduyquang753) in github/relative-time-element#298 - Use node v22 by [@​camertron](https://github.com/camertron) in github/relative-time-element#303 #### New Contributors - [@​francinelucca](https://github.com/francinelucca) made their first contribution in github/relative-time-element#297 - [@​leduyquang753](https://github.com/leduyquang753) made their first contribution in github/relative-time-element#298 - [@​camertron](https://github.com/camertron) made their first contribution in github/relative-time-element#303 **Full Changelog**: github/relative-time-element@v4.4.4...v4.4.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDYuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNi4wIiwidGFyZ2V0QnJhbmNoIjoiZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJ0ZXN0L25vdC1uZWVkZWQiXX0=--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6559 Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is part of a set of multiple pull requests looking to overhaul the calculation functions.)
When the duration to be applied is negative, this pull request makes the application order of the components reversed compared to when the duration is positive, so that adding a duration to a date then subtracting the same amount yields the same date.
Note: One test is failing on my end from the current upstream code:
This is caused by the current implementation of
roundToNearestUnitcomputing the future date to be in 2027, resulting in a 3-year difference as it only considers the year alone in this case. This will be fixed with a reimplementation of the function in one of my other pull requests.