Skip to content

Fix narrow format test expectations for Playwright 1.58.2 / newer Chromium ICU#346

Draft
Copilot wants to merge 2 commits intodependabot/npm_and_yarn/npm_and_yarn-8ff8a2d82bfrom
copilot/sub-pr-343-another-one
Draft

Fix narrow format test expectations for Playwright 1.58.2 / newer Chromium ICU#346
Copilot wants to merge 2 commits intodependabot/npm_and_yarn/npm_and_yarn-8ff8a2d82bfrom
copilot/sub-pr-343-another-one

Conversation

Copy link
Contributor

Copilot AI commented Mar 4, 2026

Playwright 1.58.2 ships a newer Chromium with updated ICU data that produces shorter narrow style strings from Intl.RelativeTimeFormat — dropping abbreviation periods and spaces (e.g. in 1 hr.in 1h, in 1 min.in 1m, 3 wk. ago3w ago).

Changes

  • test/relative-time.js — Update 15 narrow formatStyle expectations to match the new ICU output:

    Old New
    in 50 sec. in 50s
    in 1 min. / 1 min. ago in 1m / 1m ago
    in 1 hr. / 1 hr. ago in 1h / 1h ago
    in 3 wk. / 3 wk. ago in 3w / 3w ago
    in 2 yr. in 2y
  • src/duration-format-ponyfill.ts — Add as const to the 'unit' string literal to satisfy the stricter Intl.NumberFormat overload resolution introduced by the updated TypeScript version:

    // Before
    {style: 'unit', unit: nfUnit, unitDisplay: unitStyle}
    // After
    {style: 'unit' as const, unit: nfUnit, unitDisplay: unitStyle}

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…um/ICU

Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
Copilot AI changed the title [WIP] Bump npm_and_yarn group across 1 directory with updates Fix narrow format test expectations for Playwright 1.58.2 / newer Chromium ICU Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants