ietf-cms: add support for user-supplied signed attributes #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkt-signal
force-pushed
the
signed-attributes
branch
from
793b36a to
dfe52f2
Compare
Some use cases for CMS (notably the code signatures in Apple signed MachO binaries) require additional attributes to be signed. This change adds a SignWithAttrs method to cms.SignedData that accepts additional signed attributes to include.
jkt-signal
force-pushed
the
signed-attributes
branch
from
dfe52f2 to
cc523a4
Compare
|
I see this repo appears to be actively maintained again in the last few months :) Please let me know if there's something I can do to ease review. |
|
Looks useful! I've tried using this ietf-cms for signing linux kernel modules -- for that, a way to not add any attributes at all ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some use cases for CMS (notably the code signatures in Apple signed MachO binaries) require additional attributes to be signed. This change adds a SignWithAttrs method to cms.SignedData that accepts additional signed attributes to include.