Use workdir as root for everything instead of repo root #526

da1z · 2025-09-23T17:43:47Z

opening to start discussion on the approach. let me know what you think

Copilot

Pull Request Overview

This PR changes the scripts to use the current working directory as the root for file operations instead of the repository root directory. This enables the scripts to work on subdirectories of a repository or non-git managed directories.

Key changes:

Replace REPO_ROOT variable with WORKING_DIR throughout all scripts
Set WORKING_DIR to current working directory (pwd) instead of git repository root
Update all file path constructions to use working directory as base

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
scripts/powershell/update-agent-context.ps1	Replace REPO_ROOT with WORKING_DIR for agent file paths and project name extraction
scripts/powershell/setup-plan.ps1	Update template path to use working directory
scripts/powershell/create-new-feature.ps1	Simplify to use working directory, remove complex repository root detection
scripts/powershell/common.ps1	Add WORKING_DIR variable and update path functions
scripts/powershell/check-prerequisites.ps1	Update output to use WORKING_DIR instead of REPO_ROOT
scripts/bash/update-agent-context.sh	Replace REPO_ROOT with WORKING_DIR for agent file paths
scripts/bash/setup-plan.sh	Update template path to use working directory
scripts/bash/create-new-feature.sh	Simplify to use working directory, remove repository root detection
scripts/bash/common.sh	Add WORKING_DIR variable and update path functions
scripts/bash/check-prerequisites.sh	Update output to use WORKING_DIR instead of REPO_ROOT

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

scripts/bash/common.sh

scripts/powershell/common.ps1

da1z · 2025-09-23T17:45:28Z

fix for #516

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

scripts/bash/common.sh

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-23T18:36:12Z

scripts/bash/common.sh

 }

-get_feature_dir() { echo "$1/specs/$2"; }
+get_feature_dir() { echo "$WORKING_DIR/specs/$1"; }


The function signature changed from accepting two parameters (repo_root and branch) to one parameter (branch), but the function body references $1 which now represents the branch parameter. However, the function is called elsewhere in the codebase expecting the old two-parameter signature, which could cause incorrect behavior.

Copilot · 2025-09-23T18:36:12Z

scripts/powershell/common.ps1

+# Set working directory
+$script:WorkingDir = (Get-Location).Path
+
+# Function removed - no longer needed since we use WorkingDir


[nitpick] This comment is unclear about which function was removed. Consider being more specific, such as '# Get-RepoRoot function removed - no longer needed since we use WorkingDir'.

Suggested change

# Function removed - no longer needed since we use WorkingDir

# Get-RepoRoot function removed - no longer needed since we use WorkingDir

Copilot · 2025-09-23T18:36:13Z

scripts/bash/common.sh

+# Set working directory
+WORKING_DIR="$(pwd)"
+
+# Function removed - no longer needed since we use WORKING_DIR


[nitpick] This comment is unclear about which function was removed. Consider being more specific, such as '# get_repo_root function removed - no longer needed since we use WORKING_DIR'.

Suggested change

# Function removed - no longer needed since we use WORKING_DIR

# get_repo_root function removed - no longer needed since we use WORKING_DIR

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-23T20:46:43Z

scripts/powershell/create-new-feature.ps1

+# Check git availability
 try {
-    $repoRoot = git rev-parse --show-toplevel 2>$null
+    git rev-parse --show-toplevel 2>$null | Out-Null


The git command output is being redirected to Out-Null but the error stream is still redirected to $null. For consistency, consider using git rev-parse --show-toplevel >$null 2>&1 or handle both streams uniformly.

Suggested change

git rev-parse --show-toplevel 2>$null | Out-Null

git rev-parse --show-toplevel >$null 2>&1

Copilot · 2025-09-23T20:46:43Z

scripts/bash/create-new-feature.sh

    return 1
 }

-# Resolve repository root. Prefer git information when available, but fall back
-# to searching for repository markers so the workflow still functions in repositories that
-# were initialised with --no-git.
+# Set working directory


The find_repo_root function is now unused but still defined in the file. This dead code should be removed to improve maintainability.

localden · 2025-09-23T20:57:54Z

I see a potential flaw here - if we just use the working directory sourced from pwd, you're relying on the terminal being in the right context. So, if I am in VS Code, and happened to open the wrong folder in the terminal session, this can create the artifacts or look them up in the wrong location?

da1z · 2025-09-24T01:22:47Z

I see a potential flaw here - if we just use the working directory sourced from pwd, you're relying on the terminal being in the right context. So, if I am in VS Code, and happened to open the wrong folder in the terminal session, this can create the artifacts or look them up in the wrong location?

yes. if vs code opened in wrong working dir i would consider it as user error. and if it is wrong dir opened in vs code then none of / commands would work.

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-26T12:45:50Z

scripts/powershell/create-new-feature.ps1

+# Set working directory
+$workingDir = Get-Location


The variable $workingDir should use consistent naming with other scripts. All other files use $WORKING_DIR (uppercase with underscore), but this uses camelCase. Consider changing to $WORKING_DIR = (Get-Location).Path for consistency.

Copilot · 2025-09-26T12:45:51Z

scripts/bash/create-new-feature.sh


-TEMPLATE="$REPO_ROOT/.specify/templates/spec-template.md"
+TEMPLATE="$WORKING_DIR/.specify/templates/spec-template.md"
+


[nitpick] The empty line at line 76 appears to be unnecessary whitespace that doesn't add value to the code structure.

Suggested change

Use workdir as root for all folders instead of repo root

c31f9ba

da1z requested a review from localden as a code owner September 23, 2025 17:43

Copilot AI review requested due to automatic review settings September 23, 2025 17:43

Copilot AI reviewed Sep 23, 2025

View reviewed changes

scripts/bash/common.sh Outdated Show resolved Hide resolved

scripts/powershell/common.ps1 Outdated Show resolved Hide resolved

address copilot comment

a9eec6a

da1z requested a review from Copilot September 23, 2025 18:07

Copilot AI reviewed Sep 23, 2025

View reviewed changes

scripts/bash/common.sh Outdated Show resolved Hide resolved

scripts/bash/common.sh Show resolved Hide resolved

address comments

8935e9b

da1z requested a review from Copilot September 23, 2025 18:35

Copilot AI reviewed Sep 23, 2025

View reviewed changes

cleanup

2318a5c

da1z requested a review from Copilot September 23, 2025 20:46

Copilot AI reviewed Sep 23, 2025

View reviewed changes

Merge branch 'main' into work-dir

4887f89

da1z requested a review from Copilot September 26, 2025 12:45

Copilot AI reviewed Sep 26, 2025

View reviewed changes

	# Function removed - no longer needed since we use WorkingDir
	# Get-RepoRoot function removed - no longer needed since we use WorkingDir

	# Function removed - no longer needed since we use WORKING_DIR
	# get_repo_root function removed - no longer needed since we use WORKING_DIR

	git rev-parse --show-toplevel 2>$null \| Out-Null
	git rev-parse --show-toplevel >$null 2>&1


		TEMPLATE="$REPO_ROOT/.specify/templates/spec-template.md"
		TEMPLATE="$WORKING_DIR/.specify/templates/spec-template.md"

Use workdir as root for everything instead of repo root #526

Are you sure you want to change the base?

Use workdir as root for everything instead of repo root #526

Conversation

da1z commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

da1z commented Sep 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

localden commented Sep 23, 2025

Uh oh!

da1z commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

da1z commented Sep 23, 2025 •

edited

Loading

da1z commented Sep 24, 2025 •

edited

Loading