"undefined" can be the name of a parameter, too #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BekaValentine
requested changes
Jan 29, 2024
| @@ -2412,6 +2412,9 @@ inherit .return_or_yield | |||
|
|
|||
| ; the value of undefined is the undefined primitive | |||
| edge @undefined.value -> @undefined.builtins_undefined | |||
|
|
|||
| ; HACK: `undefined` is a perfectly cromulent name for a parameter, but the parser thinks it means this node instead. For the moment, work around the problem this causes by giving all `undefined` nodes covalues like parameters enjoy. | |||
There was a problem hiding this comment.
My only suggestion is add !!!! before the HACK to be in line with other similar comments. I try to use four exclamation points for things that we'll want to search for later, and then use a tag like "TODO" or "HACK" to distinguish what sort they are.
BekaValentine
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When your function has a parameter named
undefined, the parser makes it into an(undefined)node, distinct from all other parameters, and it doesn't get acovalue. This should probably be fixed in the parser, but in the interest of expedience (you'd be surprised/impressed/dismayed at how often this arises), we can work around the problem in the interim by just letting(undefined)sub in for a param—or, otherwise put: if it walks like a parameter, and it quacks like a parameter, it had better have a covalue like a parameter.https://github.com/github/aleph/issues/3205