Support JSX elements in TSX #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyakubovich
force-pushed
the
ey/support-tsx-jsx-element
branch
from
8adffbd
to
784376b
Compare
| // ^ defined: 11 | ||
| // ^ defined: 11 | ||
|
|
||
| const el2 = <x></x> |
There was a problem hiding this comment.
I'm not familiar with tsx, so this is a question for my understanding. The x here is a reference, but what about foo above? Is that an unresolved reference, or is it treated as a literal because it doesn't resolve to anything?
There was a problem hiding this comment.
In this example, foo is an undefined reference. The spec doesn't seem to define much beyond the grammar: https://facebook.github.io/jsx/.
For TSX, the TS handbook also defines the rules around type checking: https://www.typescriptlang.org/docs/handbook/jsx.html#type-checking
Specifically, the element tags need to be declared inside some interfaces and also there are rules regarding tags staring with lower case and upper case.
- Adds support for JSX elements:
<Foo attr=val>{expr}</Foo>
<Foo.Bar.Baz attr=val />
- The grammar uses nested_identifier for tags in the
Foo.Bar.Baz form. It's the same symbol as what's used
in namespaces: namespace Foo.Bar.Baz {}
As such it ends up producing a bit of junk (unconnected cliques)
but I don't know if it can be fixed w/o tree sitter queries
supporting matching only if under a specified ancestor.
- Unlike JavaScript, TypeScript requires variables to be declared.
In JSX, <foo attr={x = 1}> {y = 2} </foo> is allowed if x, y are
not in scope. They'll be created on first use. In TSX, this is
disallowed which simplifies lexical_scope propogation compared to
the JS TSG implementation.
eyakubovich
force-pushed
the
ey/support-tsx-jsx-element
branch
from
784376b
to
1e12072
Compare
hendrikvanantwerpen
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for JSX elements: {expr} <Foo.Bar.Baz attr=val />
The grammar uses nested_identifier for tags in the Foo.Bar.Baz form. It's the same symbol as what's used in namespaces: namespace Foo.Bar.Baz {}
As such it ends up producing a bit of junk (unconnected cliques) but I don't know if it can be fixed w/o tree sitter queries supporting matching only if under a specified ancestor.
Unlike JavaScript, TypeScript requires variables to be declared. In JSX, <foo attr={x = 1}> {y = 2} is allowed if x, y are not in scope. They'll be created on first use. In TSX, this is disallowed which simplifies lexical_scope propogation compared to the JS TSG implementation.