remove .to.be.accessible() checks #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
force-pushed
the
remove-to-be-accessible-checks
branch
from
26d6643 to
d738639
Compare
owenniblock
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
I'm torn with this one, I know you can test partial pages with axe without the rules like the main one.
The shadow DOM issue is a problem though. Maybe we can feed this back to Deque 🤔
Approving anyway, I guess this will still get tested by axe further down our stack anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While these checks are nice in theory, they actually aren't properly executed. They need to be
awaited and doing so causes errant failures, for example the HTML under test does not have a<main>check. Consequently I don't think they'd be useful to get working, especially as axe has problems checking shadowdom, despite the shadowdom being accessible.