Simplify events #73
Merged
Simplify events #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenniblock
approved these changes
Feb 16, 2024
|
|
||
| const currentIndex = tabs.indexOf(tabs.find(e => e.matches('[aria-selected="true"]'))!) | ||
| const vertical = tab.closest('[role="tablist"]')?.getAttribute('aria-orientation') === 'vertical' | ||
| const prevTab = event.code === 'ArrowLeft' || (vertical && event.code === 'ArrowUp') |
There was a problem hiding this comment.
Reminder for myself to check that we're setting the aria-orientation when we set horizontal or vertical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies some of the logic around event handlers; prior to this change the event handlers were arrow functions inside
addEventListenerinside theconnectedCallback, which made it harder to see what was happening inconnectedCallback. This PR moves them out into their own private functions, instead.It also simplifies the logic for the functions; they were doing a lot of unnecessary checks, and
handleKeydownhad some logic spread around the codebase in a function declaration. This now moves the logic inline so that the functions read completely, without having to jump around the codebase.