Refactor setup code to call into selecttab #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
force-pushed
the
refactor-setup-code-to-call-into-selecttab
branch
from
6191a4d to
a83a574
Compare
owenniblock
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup code in the
connectedCallbackis quite similar toselectTab, except thatselectTabfocuses and dispatches events. If we guard those with a flag that is only true after the first initial setup, it means we can share the logic, which means that changes to the logic don't need to happen in two places, and it'll be less error prone. It also more effectively conveys the concept of what the setup code is doing: selecting a tab.Review with whitespace changes removed