Fix set aria selected #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenniblock
approved these changes
Feb 19, 2024
| @@ -31,6 +31,8 @@ import '@github/tab-container-element' | |||
| </tab-container> | |||
| ``` | |||
|
|
|||
| If none of the tabs have `aria-selected=true`, then the first tab will be selected automatically. You can also add the `default-tab=N` attribute to avoid having to set `aria-selected=true` on the desired tab. | |||
There was a problem hiding this comment.
Should we specify that N is a 0-based index value here?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in v4 that didn't have requisite tests; adding
aria-selected=trueon a tab should make that the default selected tab.The problem is that we determined the index before properly setting up the tabs. We can instead defer selecting the default index and ensure that it is determined when the setup code is run.
Additionally, to make things even easier, this now accepts a
default-tabattribute which it will attempt to use if present.