Conversation
…they do not depend upon display resolution but only on printer paper size. Added astig polar plot to stand removal report. Saved user data of report to recall when run again. Updated polar plot logic to enable report to grab it's image and also make it's size proportional to the users screen size.
…that item can be identified in the polar plot.
…s the current wave front. Disabled the load of last remove test stand astig files. Because that needs more work to enable by adding the files and rotation direction to the rotation list.
…ble and added a hover over astig plot right end point. That will select that wave front in the wave front list and highlight the table entry as well.
… so thick on low resolution screens.
… line. Second click restore line
…not have the null added to them. Updated subtract dialog help info. Chaned subtract dialog not to show the currently selected wave front since you usually don't want to subtract the same wave front from itself.
atsju
reviewed
May 27, 2025
| #include "wavefront.h" | ||
| #include <QTableWidgetItem> | ||
|
|
||
| QT_CHARTS_USE_NAMESPACE |
Collaborator
There was a problem hiding this comment.
What does this do ? Can we avoid using namespace in .h ? It often creates conflicts
Owner
Author
There was a problem hiding this comment.
Qt has an include structure for charts that I never remember exactly how to address. The .h file did not work until I added that which I got from their example code. Without out using the complier thinks on of the polarchart classes I added is not defined. I don't have time to figure out the right syntax. If you desire you can provide the correct thing and I will update.
Collaborator
There was a problem hiding this comment.
I will fix later if it clashes. Thanks for the insight as a Google search didn't lead me to result.
Co-authored-by: Julien Staub <atsju2@yahoo.fr>
gr5
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge as far as I can tell.
Corrected loading nulled image so that it remembers the null.
Improved the interaction on astig polar plot
Improved the stand astig removal report to show images at a reasonable size no matter the resolution of the computer that generates the report.