Conversation
|
I don't understand why you are removing this "reset" feature? Normally you have to exit and restart DFTF to reset this feature but with PR #201 you can do this without losing all your loaded wavefronts. What's wrong with that? Why are you taking it away? I think maybe you misunderstand the feature. |
|
Hi @gr5 I did not remove the feature. Dale added the feature + an extra "debug" button that does nothing. I removed this debug button but kept the real feature. |
|
The reset is a function and not a setting. So I think it is more appropriate to be in a menu. However the more elaborate invert feature discussed on the list and presented by George would be a combination of settings and function. I noticed the Debug show up in the menu but never investigated it. It must have been from some old code. There are times I use something like that to test out a feature that would normally require several GUI operations. However I usually intend to comment it out for release. I think there is one in some other menu but did investigate. I have a vague memory of wanting to move it from the original menu and put it in the tools area. |
RevisionHistory.html
Outdated
| <li>New button to remove wavefront auto invert.</li> | ||
| <li>Fixed bug that was causing intermitent crashes.</li> | ||
| <li>Fix discrepency in wavefront 2D cut angle versus wavefront profile.</li> | ||
| <li>Fix wavefront subtraction.</li> |
There was a problem hiding this comment.
Looking at the code it was a bug but for the users, it's just an improvement where before you could subtract any of the wavefronts but now you can't subtract a wavefront from itself. So I'm calling it an "improvement".
😧 Oops! I see that now. I must have really skimmed the changes badly. |
Co-authored-by: gr5 <gr5@users.noreply.github.com>
Co-authored-by: gr5 <gr5@users.noreply.github.com>
gr5
left a comment
gr5
left a comment
There was a problem hiding this comment.
looks great. You can tag it and make the release but please don't finalize it until I've tested the installer and the released version.
|
If you are talking to me: I can't push tags. I have no rights in this repo. |
|
Okay then, well if you merge this I will push the tag. |
3 participants
remove a thing introduced in #201 that shall not appear to end user.
IMHO This new auto invert option should be in preferences. Not in the main menu.
Anyway: new feature means minor version update not only patch. => v7.4.0