Skip to content

fix reading mirror config ellipse#226

Merged
gr5 merged 1 commit intogithubdoe:masterfrom
atsju:JST/fix221
Aug 14, 2025
Merged

fix reading mirror config ellipse#226
gr5 merged 1 commit intogithubdoe:masterfrom
atsju:JST/fix221

Conversation

@atsju
Copy link
Collaborator

@atsju atsju commented Aug 14, 2025

close #221

I did not check other spellings.
However this confirms having abstraction classes for this type of things makes sense.

@atsju atsju requested review from githubdoe and gr5 August 14, 2025 16:05
Copy link
Collaborator

@gr5 gr5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - this is the very kind of bug (upper/lower case sensitivity) I was talking about earlier today. And it may even be my code as well.

I built and tested this. It works.

@atsju
Copy link
Collaborator Author

atsju commented Aug 14, 2025

I don't know if it's case sensitive. If you look closely you see S and P are inverted also.

@gr5 gr5 merged commit db86845 into githubdoe:master Aug 14, 2025
14 checks passed
@atsju atsju deleted the JST/fix221 branch December 23, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mirror config file doesn't save elliptical state

2 participants