Skip to content

update changelog to prepare for 8.0.0-alpha1#236

Merged
atsju merged 6 commits intogithubdoe:masterfrom
atsju:JST/changelog800
Aug 26, 2025
Merged

update changelog to prepare for 8.0.0-alpha1#236
atsju merged 6 commits intogithubdoe:masterfrom
atsju:JST/changelog800

Conversation

@atsju
Copy link
Collaborator

@atsju atsju commented Aug 19, 2025

close #225

First of all: yes I messed with this file.
I'm sorry but I think it's actually more readable like this. I used an autoformatter and it helped find out many places that had incorrect html tags. html is in fact quite permissive.

So kindly just focus on test of 8.0.0 or look at final result in your browser.

Also I propose that we invert the order of the list. Maybe have 8.0.0 at top of file and v1 at bottom. What do you think ?

@atsju atsju requested review from githubdoe and gr5 August 19, 2025 16:56
@atsju
Copy link
Collaborator Author

atsju commented Aug 19, 2025

@githubdoe if you have time, kindly approve (or reject) the other opened pull requests. No pressure about the timeline I just want to ensure you see them.

Copy link
Owner

@githubdoe githubdoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo "mirro" line 550

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's RMS plot again? Is this where you fixed the spinnable arrow thing that shows different diameters? Maybe you can explain slightly better. Also I don't want to scare anyone into thinking all analysis with 7.4.0 were bad and need to be thrown out. So maybe (if it's true) say "fix minor bug...".

The terminology that I think Dale uses:

3d plot (top left plot)
contour plot (top right plot)
profile plot (one (or sometimes 16) diameter of the wavefront(s))

Copy link
Collaborator Author

@atsju atsju Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spintable was fixed in 7.4.0 : Fix discrepency in wavefront 2D cut angle versus wavefront profile

RMS plot: as Dale explained. Batch process, you see RMS values and "click to select" was broken

@githubdoe
Copy link
Owner

githubdoe commented Aug 20, 2025

George. The RMS plots appear when pressing the filter button and when doing batch process to let you monitor the process by seeing the astig and rms values of each wave front. You can easily then see which ones might be outliers and then decide if they should be used or not. Usually outliers in RMS are caused by low signal to noise ratio causing many unwrap errors.

Those plots let one hover over the points on the graph and pop up the wave front associated with them just like I did with the astig polar plots. He broke that hover and/or click on function to begin with and has now corrected it.

@atsju atsju requested review from githubdoe and gr5 August 20, 2025 09:07
@gr5
Copy link
Collaborator

gr5 commented Aug 20, 2025

Ah! Got it.

Copy link
Collaborator

@gr5 gr5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care if newest is at the top or the bottom. Every time I open that file I am surprised that the newest is at the bottom but I don't think users look at it as they see the same info on the releases page on github.

@atsju
Copy link
Collaborator Author

atsju commented Aug 20, 2025

Every time I open that file I am surprised that the newest is at the bottom

I will revert. I agree people probably do not look at it but still...

@atsju
Copy link
Collaborator Author

atsju commented Aug 20, 2025

I reversed order of the revisions.

You might want to look at last commit also 312675a. I got Copilot help for review.

@atsju atsju requested a review from gr5 August 20, 2025 13:50
@atsju atsju requested a review from gr5 August 20, 2025 14:00
@gr5
Copy link
Collaborator

gr5 commented Aug 20, 2025

You might want to look at last commit also 312675a. I got Copilot help for review.

I just checked all those. Looks good. It even got an "li" tag.

@atsju
Copy link
Collaborator Author

atsju commented Aug 20, 2025

@gr5 sorry. Additional changes again

@atsju atsju mentioned this pull request Aug 21, 2025
@atsju
Copy link
Collaborator Author

atsju commented Aug 25, 2025

@githubdoe Kindly review #238 and #240 when you have time. Than I will release v8.0.0-alpha1
#244 is also to review. But can wait if necessary.

I have nothing planned/masked to come after those. If I find time I might work on #234 but I probably won't have time soon.

@atsju atsju merged commit c6ec43f into githubdoe:master Aug 26, 2025
14 checks passed
@atsju atsju deleted the JST/changelog800 branch August 26, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8.0.0 release. Qt6

3 participants

Comments