Skip to content

[DRAFT FOR TESTS] adding clang tidy comments on modified code #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atsju wants to merge 1 commit into from
Closed

[DRAFT FOR TESTS] adding clang tidy comments on modified code #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions .github/workflows/build-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ env:

jobs:
build-linux:
permissions:
contents: read
pull-requests: write
strategy:
fail-fast: false
matrix:
Expand All @@ -20,7 +23,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- run: sudo apt update
- run: sudo apt install -y apt-utils build-essential wget qt6-base-dev-tools qt6-declarative-dev qt6-multimedia-dev libqt6charts6-dev libqt6datavisualization6-dev libqt6svg6-dev libopencv-core-dev libopencv-dev libqwt-qt5-6 libqwt-qt5-dev libarmadillo-dev libgl1-mesa-dev libglu1-mesa-dev
- run: sudo apt install -y apt-utils build-essential wget qt6-base-dev-tools qt6-declarative-dev qt6-multimedia-dev libqt6charts6-dev libqt6datavisualization6-dev libqt6svg6-dev libopencv-core-dev libopencv-dev libqwt-qt5-6 libqwt-qt5-dev libarmadillo-dev libgl1-mesa-dev libglu1-mesa-dev bear
- run: wget -O qwt-${{env.QWT_version}}.zip https://sourceforge.net/projects/qwt/files/qwt/${{env.QWT_version}}/qwt-${{env.QWT_version}}.zip/download?use_mirror=pilotfiber
- run: 7z x qwt-${{env.QWT_version}}.zip
- run: cd qwt-${{env.QWT_version}} ; /usr/lib/qt6/bin/qmake
Expand All @@ -29,5 +32,20 @@ jobs:
- run: /usr/lib/qt6/bin/qmake DFTFringe.pro
- uses: ammaraskar/gcc-problem-matcher@master
- run: echo "::add-matcher::.github/matcher/uic_matcher.json"
- run: make -j4

- name: capture compile_commands.json from build
run: bear -- make -j4
- run: echo "::remove-matcher owner=uic-problem-matcher::"

- name: Run C++ Linter (clang-tidy)
if: strategy.job-index == 0 #run only for first OS of the matrix
uses: cpp-linter/cpp-linter-action@v2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
style: '' # we don't want check from clang-format
lines-changed-only: 'true' # Only lines in the diff that contain additions are analyzed. Avoid noise from existing code.
thread-comments: 'update'
tidy-review: true
passive-reviews: true
ignore: 'bezier|boost|SingleApplication|spdlog|zernike|moc_*|ui_*|qwt*'
Loading