Conversation
|
@gr5 I will look at settings pane UI files as several things do not display well. I am surprised by capitalisation. Google tells me it's normal to capitalize proper nouns. |
|
|
🚀 New build available for commit |
|
🚀 New build available for commit |
|
🚀 New build available for commit |
|
Proper nouns are names of people, places, organizations, streets, products. Names. |
gr5
left a comment
gr5
left a comment
There was a problem hiding this comment.
These are great. I see so many spelling errors when going over DFTF. I should fix them more often.
I read a lot of novels. About 1 per week (40 per year - I keep track). Because of that spelling errors stand out visually to me.
I did not fix the red underlined in pictures. Kindly confirm those have wrong capitalisation and I will fix them. |
|
The titles of books and movies tend to have almost every word capitalized other than {the,of,a}. But the examples you underline above are all backwards capitalization as you probably suspect. |
|
To clarify : I don't want you to tell me what's wrong. I want to confirm my grammar understanding is correct and I can fix all of these as I see them. Catch a fish, teach fishing thing. |
|
Our messages crossed. It's clear thank you. I want to do some UI fixes but it might come after the release |
|
I tend to capitalize words I want to emphasize in titles . I view text that document user parameters as titles. So for example "Mask" is the thing being displayed. It is capitalized to separate it from the other text. These are titles not pros. |
Bold or Italic would be better for that although I don't know if that's easy to do in QT. |
|
Dale, to be clear, Julien moved this button as shown. Previously it was just above "apply" button. I think it is fine in either location and have no preference. Just wanted you to be aware. This is in addition to some spelling errors. So far, this PR looks good to me. 
|
|
@gr5 @githubdoe I have done a small video with further review of "Settings". https://youtu.be/Lb3vSjkuqo8 Recap:
|
|
Yes apply is strange. It was created by Qt Creator because of the class the widget is. It sometimes is needed and sometimes not. I wish it would work better. Removing the extra space probably can be done by adding a vertical spacer. Any work at changing the layout or spacing is usually done by using Qt Creator and its UI editor. I don't know if you are familiar with that process. But it will hamper your effort and can create frustration. Using an editor on the .ui file itself risks destroying Qt Creator's ability to use the file. I personally do not like the way the current preferences is presented. But it is what I came up with. The lens distortion is a feature that I would probably remove. I don't think it has ever been used by anyone. I don't use it. Well actually I did use it once just to make a paper with a grid on it to use as a focusing aid. |
|
Yes I have played a little with Qt designer (the UI tool in qt creator). I know it can be frustrating. I don't plan to edit UI files programmatically. Do you prefer the simple solution of fixed size or should I go the long path making things resizable ? I mean it's nice but it requires more tests and work to bring little value. I will remove the lens things if nobody uses it. Shall we ask on groups.io before removing ? |
Agreed. Do it all if you can figure out how to do it. I'll play with it at a few different scalings and then Dale can test it on his laptop scaling. |
|
🚀 New build available for commit |
|
🚀 New build available for commit |
|
Did you still mean for this to be in draft mode? Or do you have more to do? |
|
There is more to do. But you can merge it for release whenever you want and I can continue later. I don't think I will finish any soon. |
3 participants
No description provided.