Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch menubar for windows position #1252

Closed
wants to merge 2 commits into from
Closed

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 16, 2024

Fixes #1162

Upstream fix raised @ max-mapper/menubar#479. Once released, we can remove the menubar@9.4.0 patch

@setchy setchy added the bug Something isn't working label Jun 16, 2024
@setchy setchy added this to the Release 5.9.0 milestone Jun 16, 2024
@setchy setchy added the platform:windows Related to windows build label Jun 16, 2024
@afonsojramos
Copy link
Member

I assume this is to be merged only after @camille-avatarmedical's testing?

@setchy
Copy link
Member Author

setchy commented Jun 16, 2024

I assume this is to be merged only after @camille-avatarmedical's testing?

Correct. I really need to setup a Windows VM 🙃

@setchy setchy marked this pull request as draft June 16, 2024 23:03
@setchy setchy removed this from the Release 5.9.0 milestone Jun 17, 2024
@setchy
Copy link
Member Author

setchy commented Jun 25, 2024

max-mapper/menubar#479 has been merged upstream, so will close this PR and await a new menubar package version

@setchy setchy closed this Jun 25, 2024
@setchy setchy deleted the patch/menubar-windows branch July 11, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform:windows Related to windows build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitify open on middle of double screen on Windows
2 participants