-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reset to default settings #1321
Conversation
I perceive that icon as "undo my last change," not "undo all changes, ever." I could, therefore, click it and get effective data loss without intending... |
Is there an alternative icon you'd propose - https://primer.style/foundations/icons? Would there be a different location you'd prefer? I figured the hover text was enough 🤷♂️ |
I'd argue more against the feature, than the icon itself. Why would we want this? (But if we really want this, I'd say actual text aligned to the right saying "Reset to defaults *currentUndoIconHere*") |
@setchy took the liberty to push to this branch the option I think is the most viable. Hope that's okay. |
Works for me |
I think it is a bit more clear right out of the gate and it's only visible if you're looking for it. Which, for a "deep" setting, makes sense! |
Add a
reset default settings
option. Of increasing usefulness as we've been adding, and may continue to add more settings in future.