Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icons to header sections #1329

Merged
merged 1 commit into from
Jul 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/settings/AppearanceSettings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
CommentIcon,
IssueClosedIcon,
MilestoneIcon,
PaintbrushIcon,
TagIcon,
} from '@primer/octicons-react';
import { ipcRenderer } from 'electron';
Expand All @@ -27,6 +28,7 @@ export const AppearanceSettings: FC = () => {
return (
<fieldset className="mb-3">
<legend id="appearance" className="mb-1 mt-2 font-semibold">
<PaintbrushIcon className="mr-2" />
Appearance
</legend>
<RadioGroup
Expand Down
2 changes: 2 additions & 0 deletions src/components/settings/NotificationSettings.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { BellIcon } from '@primer/octicons-react';
import { type FC, type MouseEvent, useContext } from 'react';
import { AppContext } from '../../context/App';
import { GroupBy } from '../../types';
Expand All @@ -11,6 +12,7 @@ export const NotificationSettings: FC = () => {
return (
<fieldset className="mb-3">
<legend id="notifications" className="mb-1 mt-2 font-semibold">
<BellIcon className="mr-2" />
Notifications
</legend>
<RadioGroup
Expand Down
2 changes: 2 additions & 0 deletions src/components/settings/SystemSettings.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { DeviceDesktopIcon } from '@primer/octicons-react';
import { type FC, useContext } from 'react';
import { AppContext } from '../../context/App';
import Constants from '../../utils/constants';
Expand All @@ -10,6 +11,7 @@ export const SystemSettings: FC = () => {
return (
<fieldset className="mb-3">
<legend id="system" className="mb-1 mt-2 font-semibold">
<DeviceDesktopIcon className="mr-2" />
System
</legend>
<Checkbox
Expand Down
8 changes: 7 additions & 1 deletion src/routes/Filters.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import { FilterRemoveIcon } from '@primer/octicons-react';
import {
FeedPersonIcon,
FilterRemoveIcon,
NoteIcon,
} from '@primer/octicons-react';
import { type FC, useContext } from 'react';
import { Header } from '../components/Header';
import { Checkbox } from '../components/fields/Checkbox';
Expand Down Expand Up @@ -33,6 +37,7 @@ export const FiltersRoute: FC = () => {
<div className="flex-grow overflow-x-auto px-8">
<fieldset className="mb-3">
<legend id="notifications" className="mb-1 mt-2 font-semibold">
<FeedPersonIcon className="mr-2" />
Users
</legend>
<Checkbox
Expand Down Expand Up @@ -61,6 +66,7 @@ export const FiltersRoute: FC = () => {

<fieldset className="mb-3">
<legend id="appearance" className="mb-1 mt-2 font-semibold">
<NoteIcon className="mr-2" />
Reason
</legend>
<span className="text-xs italic">
Expand Down
28 changes: 28 additions & 0 deletions src/routes/__snapshots__/Filters.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 42 additions & 0 deletions src/routes/__snapshots__/Settings.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.