-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sidebar): highlight selected route #1330
Conversation
I expected to love it, but found the video confusing. I think it's because only two icons change color? Also, something about the red throws me off, like it's an error state. That could just be because I'm not the one controlling it, though. So may or may not be valid feedback :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good :)
It's meant to be orange, but agree it does come across differently. Is there a different color you think would work well? |
Maybe no color, but a little triangle next to it? Let me draw something up! |
Yeah I agree that moving the icon would be weird. |
agree, didn't intend for the icons to move around in the final version, hence the Nonetheless, will look to update the hover opacity instead |
Me again 😅 How about a simple tailwind ring @afonsojramos @bmulholland ? I played around with different opacity combinations but found it not very useful. |
I like the ring. Personal opinion though. |
Updated to use a shadow. imho, this is the best of the options explored above. Screen.Recording.2024-07-14.at.8.34.11.AM.mov |
Moving back to draft as @afonsojramos is looking into some things on his side |
Closing this concept for now |
Highlight sidebar button when route being shown