-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: zoom buttons #1333
feat: zoom buttons #1333
Conversation
@afonsojramos - nice pivot. Seems much more user-friendly and predictable. minor nit: could it be a little smaller (vertically). Otherwise, lgtm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks 😄
@setchy updated the image now. Looking way sleeker now! |
Our zoom controls went on a diet! Nice! |
…com:gitify-app/gitify into feat/zoom-buttons
I haven't been able to re-launch the app with a saved steps to reproduce:
|
pushed a small update to load the existing settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, @afonsojramos - lgtm!
7a890b8
to
0794b3c
Compare
This is the second iteration of the zoom feature after #1318.
Closes #1312.
Had to add a timeout to the listening to the
resize
event because it was very trigger-happy. Found a fix by doing debounced update calls. More info here@adufr @setchy Let me know your thoughts.