Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): restore oauth2 flow functionality #1456

Merged
merged 4 commits into from
Aug 14, 2024
Merged

fix(auth): restore oauth2 flow functionality #1456

merged 4 commits into from
Aug 14, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Aug 11, 2024

Resolves #1452 and reintroduces Gitify GitHub Auth flow.

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy added this to the Release 5.13.0 milestone Aug 11, 2024
@github-actions github-actions bot added the bug Something isn't working label Aug 11, 2024
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@afonsojramos
Copy link
Member

Nice! 🚀

Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. UI-wise, is it worth adding a link to say that hardware 2FA tokens aren't yet supported, and to use PAT if you need one of those to login to Github?

@setchy setchy merged commit fd834c3 into main Aug 14, 2024
12 checks passed
@setchy setchy deleted the fix/oauth-login branch August 14, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login with OAuth App does not open even if everything is entered
3 participants