Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update sidebar labels #1538

Merged
merged 1 commit into from
Sep 18, 2024
Merged

refactor: update sidebar labels #1538

merged 1 commit into from
Sep 18, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Sep 17, 2024

Change casing used for sidebar labels

@setchy
refactor: update sidebar labels
2072b27 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy added this to the Release 5.15.0 milestone Sep 17, 2024
@github-actions github-actions bot added the refactor Refactoring of existing feature label Sep 17, 2024
bmulholland
bmulholland approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're standardizing on sentence case?

@setchy
Copy link
Member Author

setchy commented Sep 18, 2024

So we're standardizing on sentence case?

I think so. Looks a little better imho

@setchy setchy merged commit 32c7118 into main Sep 18, 2024
12 checks passed
@setchy setchy deleted the refactor/sidebar-labels branch September 18, 2024 10:51
@afonsojramos
Copy link
Member

afonsojramos commented Sep 18, 2024 •
edited
Loading

Maybe it is worth adding this somewhere? (That we're using sentence case going forward)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@setchy @afonsojramos @bmulholland