-
Notifications
You must be signed in to change notification settings - Fork 250
kellerEToro #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
kellerEToro #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds branding documentation for "Keller" to the GitKraken CLI repository. The PR introduces three new branding report files (in Markdown with HTML, pure Markdown, and JSONC formats), updates the README with extensive branding information, and adds a GitHub Actions workflow to attest documentation files.
Key changes:
- Addition of comprehensive branding documentation in multiple formats (MD, JSONC)
- Integration of personal branding content into the project README
- New GitHub Actions workflow for documentation attestation
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
keller-branding-report.md |
New branding report with HTML-enhanced Markdown containing logos, social links, color palettes, and contact information |
keller-branding-report-puro.md |
Pure Markdown version of the branding report for maximum compatibility |
keller-branding-report.jsonc |
Structured JSON with comments format of branding metadata |
README.md |
Major modifications adding branding sections, personal information, and logos throughout the GitKraken CLI documentation |
.github/workflows/attest-docs.yml |
New workflow to attest documentation and licensing files using GitHub's build provenance action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Use "gk [command] --help" for more information about a command. | ||
| ``` | ||
| ```markdown |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect code fence language. This should be an empty string or "bash" instead of "markdown" since the content is a command line example, not markdown code.
| ```markdown | |
| ```bash |
| ```markdown | ||
| ``` |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect code fence language. This should be "bash" or "sh" instead of "markdown" since this is a shell command.
| ```markdown | |
| ``` | |
| ```bash |
| <div align="center"> | ||
| <img alt="Logo Keller" src="https://raw.githubusercontent.com/Kelleretoro/ssh-log-cli/main/assets/logo.png" width="220"/> | ||
| </div> | ||
|
|
||
| # Create a Pull Request | ||
| gk work pr create --ai | ||
|
|
||
| ``` | ||
| <div align="center"> | ||
| <img alt="Letrero Keller" src="https://raw.githubusercontent.com/Kelleretoro/ssh-log-cli/main/assets/letrero.jpg" width="320"/> | ||
| </div> |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section appears to have been corrupted. Lines 97-103 contain HTML image tags in the middle of the "Workflows" section, replacing what should be workflow commands (gk work push, gk work pr create --ai, and the closing code fence). This breaks the code example and is not semantically appropriate here. The workflow example is now incomplete and malformed.
| **KELLER_LICENSE:** | ||
| - BSD 3-Clause (software) | ||
| - CC BY-ND 4.0 (imágenes, logos y colores) | ||
| [Ver licencia completa](./LICENSE) |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing line break before the LICENSE section. Line 232 should have a blank line after it before line 233 to properly separate the LICENSE information from the KEYWORDS field.
| [Ver licencia completa](./LICENSE) | |
| [Ver licencia completa](./LICENSE) |
|
|
||
| --- | ||
|
|
||
| ## KELLER_PALLETS |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error: "PALLETS" should be "PALETTES". A pallet is a wooden platform for shipping goods, while a palette is a range of colors used in design.
| ## KELLER_PALLETS | |
| ## KELLER_PALETTES |
|
|
||
| --- | ||
|
|
||
| ## KELLER_PALLETS |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error: "PALLETS" should be "PALETTES". A pallet is a wooden platform for shipping goods, while a palette is a range of colors used in design.
| ## KELLER_PALLETS | |
| ## KELLER_PALETTES |
| "#kellerETojo", | ||
| "#kellerEToro" | ||
| ], | ||
| "KELLER_PALLETS": [ |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error: "KELLER_PALLETS" should be "KELLER_PALETTES". A pallet is a wooden platform for shipping goods, while a palette is a range of colors used in design.
| "KELLER_PALLETS": [ | |
| "KELLER_PALETTES": [ |
| **KELLER_NAME:** "Oscar Rojas Ortiz | ORO" | ||
| **KELLER_SOCIAL:** Instagram [@kelleretoro](https://instagram.com/kelleretoro) | Facebook [kelleretoroph](https://facebook.com/kelleretoroph) | ||
| **KELLER_HASHTAGS:** #KellerOjo #kellerETojo #kellerEToro | ||
| **KELLER_PALLETS:** #8dffe9, #4bfbd6, #283431, #01f8fe, #2a302b |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error: "KELLER_PALLETS" should be "KELLER_PALETTES". A pallet is a wooden platform for shipping goods, while a palette is a range of colors used in design.
| **KELLER_PALLETS:** #8dffe9, #4bfbd6, #283431, #01f8fe, #2a302b | |
| **KELLER_PALETTES:** #8dffe9, #4bfbd6, #283431, #01f8fe, #2a302b |
| @@ -1,30 +1,44 @@ | |||
| # 🚀 GitKraken CLI | |||
| # � Reportes de Branding | |||
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The character "�" appears to be a mojibake/encoding error. This should likely be an emoji icon like "📒" or another relevant icon.
| # � Reportes de Branding | |
| # 📒 Reportes de Branding |
| - [`keller-branding-report-puro.md`](./keller-branding-report-puro.md): Versión Markdown puro (máxima compatibilidad y sin HTML). | ||
|
|
||
| Ambos archivos están disponibles en el repositorio y en la carpeta Descargas del autor. | ||
| # �🚀 GitKraken CLI |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The character "�" appears to be a mojibake/encoding error. This should likely be the same emoji icon that appears in the first heading or removed entirely.
This pull request introduces new branding documentation and enhances the project’s documentation structure and automation. The main changes include adding two detailed branding reports (one in advanced Markdown with HTML and one in pure Markdown), a structured branding report in JSONC, updates to the
README.mdto include branding information and links to the new reports, and a new GitHub Actions workflow to attest documentation files.Branding documentation additions:
keller-branding-report.md(advanced Markdown with HTML) andkeller-branding-report-puro.md(pure Markdown) to provide comprehensive branding information, including logos, author details, social links, hashtags, color palettes, license, and contact info. [1] [2]keller-branding-report.jsoncfor structured, machine-readable branding metadata.README and documentation improvements:
README.mdto reference the new branding reports, add branding and author information, improve formatting, and enhance compatibility (e.g., Markdown code blocks, image alt text, and links). [1] [2] [3] [4] [5] [6]Automation and workflow:
.github/workflows/attest-docs.ymlto automatically attest documentation and licensing files on push tomainor via manual trigger, improving documentation integrity and provenance.