Skip to content

Fix npm security vulnerabilities via yarn resolutions #21236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geropl merged 1 commit into from
Jan 12, 2026
Merged

Fix npm security vulnerabilities via yarn resolutions #21236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@
]
},
"resolutions": {
"sha.js": "2.4.12"
"sha.js": "2.4.12",
"@babel/traverse": "^7.23.2",
"browserify-sign": "^4.2.5",
"cipher-base": "^1.0.5",
"elliptic": "^6.6.1",
"loader-utils": "^2.0.4",
"exec-sh": "^0.4.0",
"pbkdf2": "^3.1.3",
"tough-cookie": "^4.1.3"
Comment on lines +29 to +37
Copy link
Contributor

@kylos101 kylos101 Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting. I take it this is for any component, which is different from dev/npm-tools which is for global dependencies?

Copy link
Member Author

@geropl geropl Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"dev/npm-tools" is just for CLI tools that we want to have installed in our dev container.

This package.json is for all packages that are shared by our components (basically the superset of dashboard + server dependencies).

And the resolutions is a specific way to pin-point transitive dependencies, which you otherwise don't have control over.

}
}
15 changes: 15 additions & 0 deletions resolutions-explanation.md
View file
Open in desktop
Copy link
Contributor

@kylos101 kylos101 Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems unnecessary, maybe you can remove?

Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Yarn Resolutions

Resolutions in `package.json` force specific versions of transitive dependencies. These are needed because yarn.lock pins older versions even when semver ranges allow newer ones.

| Package | Version | Reason |
|---------|---------|--------|
| sha.js | 2.4.12 | Pre-existing resolution |
| @babel/traverse | ^7.23.2 | CVE-2023-45133: arbitrary code execution via crafted code |
| browserify-sign | ^4.2.5 | Pulls in elliptic ^6.6.1 with security fixes |
| cipher-base | ^1.0.5 | CVE-2025-21531: prototype pollution vulnerability |
| elliptic | ^6.6.1 | CVE-2024-48949: signature verification bypass |
| loader-utils | ^2.0.4 | CVE-2022-37601: prototype pollution via url property |
| exec-sh | ^0.4.0 | Removes vulnerable merge@1.x dependency (GHSA-7wpw-2hjm-89gp) |
| pbkdf2 | ^3.1.3 | CVE-2025-21532: prototype pollution vulnerability |
| tough-cookie | ^4.1.3 | CVE-2023-26136: prototype pollution in cookie parsing |
Loading