-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Upgrade Caddy to 2.11.0-beta.2 across proxy components #21242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
kylos101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple observations, no blocking questions or concerns, adding ✅ to unblock.
| RUN go install golang.org/dl/go1.24.3@latest && \ | ||
| go1.24.3 download && \ | ||
| rm -rf /usr/local/go && \ | ||
| mv /go /usr/local/go && \ | ||
| mv /usr/local/go/bin/go1.24.3 /usr/local/go/bin/go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, i see caddy 2.10 has go built-in now as the base image
components/proxy/Dockerfile
Outdated
| --with github.com/gitpod-io/gitpod/proxy/plugins/frontend_dev=/plugins/frontend_dev | ||
|
|
||
| FROM cgr.dev/chainguard/wolfi-base:latest@sha256:815b27b8a70713c70404e44a718eddd52ea6f4a2bfad5f56455b52cd2789a9b2 | ||
| FROM caddy/caddy:2.10.2-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only bummer here, is that we're switching from chainguard to caddy. But I get it, and see dashboard and ide-proxy already use.
Co-authored-by: Ona <no-reply@ona.com>
- Update Dockerfile to use caddy:2.10.2-builder and caddy/caddy:2.10.2-alpine - Update all 10 plugin go.mod files from Caddy v2.7.6 to v2.10.2 - Fix sshtunnel plugin: replace deprecated caddy.Listen() with NetworkAddress.Listen() - Remove intermediate Go version upgrade stage (caddy:2.10.2-builder includes Go 1.24+) Fixes several HIGH severity vulnerabilities: - GHSA-7jwh-3vrq-q3m8 (pgproto3 SQL injection) - GHSA-m7wr-2xf7-cm9p (pgx SQL injection) - GHSA-mrww-27vc-gghv (pgx SQL injection) - GHSA-c33x-xqrf-c478 (quic-go DoS) - GHSA-vrw8-fxc6-2r93 (chi host header injection) Co-authored-by: Ona <no-reply@ona.com>
0dd7f3c to
142b6c2
Compare
Test ProtocolTested on preview environment
All proxy functionality verified working after Caddy 2.10.2 upgrade. |
Co-authored-by: Ona <no-reply@ona.com>
Upgrade from Caddy 2.10.2 to 2.11.0-beta.2 to fix GHSA-h8cp-697h-8c8p (Critical - authorization bypass in smallstep/certificates ACME/SCEP). - proxy: Use caddy:builder with xcaddy build v2.11.0-beta.2 - ide-proxy, dashboard: Use caddy/caddy:2.11-alpine - Update all plugin go.mod files to Caddy v2.11.0-beta.2 Co-authored-by: Ona <no-reply@ona.com>
Co-authored-by: Ona <no-reply@ona.com>
Description
Upgrade Caddy to 2.11.0-beta.2 across all proxy-related components to fix a critical security vulnerability (GHSA-h8cp-697h-8c8p).
Changes
ide-proxy & dashboard (commit 1):
caddy/caddyimage from 2.9.1 to 2.11-alpineproxy component (commit 2):
caddy:builderwithxcaddy build v2.11.0-beta.2caddy/caddy:2.11-alpinecaddy.Listen()withNetworkAddress.Listen()APIAdditional upgrade to beta.2 (commit 3):
Vulnerabilities Fixed
CRITICAL severity:
HIGH severity:
MEDIUM severity:
Note on Beta Version
Using Caddy 2.11.0-beta.2 because:
Related Issue(s)
Fixes CLC-2189
How to test
Tested on preview environment
gpl-clc-21b31317cbc2.preview.gitpod-dev.com:All tests verified on 2026-01-12.