Improve minimal mode detection: drop ConfigCat, use isDedicatedInstallation#21289
Merged
Improve minimal mode detection: drop ConfigCat, use isDedicatedInstallation#21289
Conversation
fac1fa4 to
cae9341
Compare
cae9341 to
2fa2555
Compare
2fa2555 to
1824430
Compare
mustard-mh
reviewed
Feb 5, 2026
components/dashboard/src/index.tsx
Outdated
| return; | ||
| } | ||
| // Production gitpod.io - always minimal mode | ||
| if (isProductionGitpodIo()) { |
Contributor
There was a problem hiding this comment.
&& !isWebsiteSlug
Otherwise the website redirection doesn't work
Member
Author
There was a problem hiding this comment.
@mustard-mh Cleaned up the mess, would appreciate your re-review! 🙏
1824430 to
7e76d15
Compare
…lation - Remove ConfigCat feature flag dependency for minimal mode detection - gitpod.io: always use minimal mode (synchronous, no network call) - Preview environments: use isDedicatedInstallation with localStorage caching - Dedicated/self-hosted: never use minimal mode - Replace document.write() with innerHTML to avoid deprecation issues - Change GITPOD_WITH_DEDICATED_EMU default to true in preview deployments The localStorage override (minimal_gitpod_io_mode=true/false) still works for testing. Co-authored-by: Ona <no-reply@ona.com>
7e76d15 to
8b06b57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the minimal mode detection logic by removing the ConfigCat feature flag dependency and using environment-based detection instead.
Changes
Detection Logic
isDedicatedInstallationwith localStorage cachingTechnical Improvements
document.write()withinnerHTMLto avoid deprecation issuesisDedicatedInstallationin preview environments (instant on subsequent loads)Preview Environment Default
GITPOD_WITH_DEDICATED_EMUdefault fromfalsetotrueisDedicatedInstallation=true(minimal mode OFF)GITPOD_WITH_DEDICATED_EMU=falseto test minimal mode in previewTesting
The localStorage override still works for manual testing:
localStorage.setItem('minimal_gitpod_io_mode', 'true')- force minimal modelocalStorage.setItem('minimal_gitpod_io_mode', 'false')- force full appBehavior Matrix
gitpod.ioisDedicatedInstallation=true)GITPOD_WITH_DEDICATED_EMU=false)