Seleniumworkspace #43
Conversation
subroto407
requested review from
Bishojit12,
TalhaBinAshraf1,
abzaman7,
alexiamitsaha,
gits5213 and
mridul281
| WebElement txt= driver.findElement(By.xpath("/html//body[@id='tinymce']")); | ||
| txt.clear(); | ||
| sleepTime(3000); | ||
| txt.sendKeys(Data.INPUTS_TEXT); |
There was a problem hiding this comment.
validate input text attributes
There was a problem hiding this comment.
Make add remove element dynamic with value input for add elements, remove element should correspond with add element.
| sleepTime(1000); | ||
|
|
||
| //Value Pass On input Field login popup | ||
| driver.get("https://admin:admin@the-internet.herokuapp.com/basic_auth"); |
There was a problem hiding this comment.
Make the link dynamic with concatenation for username and password. Manage username and password in the test data.
There was a problem hiding this comment.
Can't see where it validates the broken images of a page.
There was a problem hiding this comment.
Contains too many unnecessary validations!
There was a problem hiding this comment.
Can't see where it validates the disappearing elements. Make it dynamic!
| File filePath = new File(Data.DOWNLOAD_FILE_PATH); | ||
| File[] totalFiles = filePath.listFiles(); | ||
| for (File file:totalFiles) { | ||
| if (file.getName().equals("logo.png")) { |
| //Now Release CTRL | ||
| robot.keyRelease(KeyEvent.VK_CONTROL); | ||
| sleepTime(2000); | ||
|
|
There was a problem hiding this comment.
What if you download multiple files, how would you validate those?
|
|
||
| //File Download Validation | ||
| //Using String Selection Class to store the path of the file | ||
| Robot robot=new Robot(); |
There was a problem hiding this comment.
Robot class is unnecessary
abzaman7
left a comment
abzaman7
left a comment
There was a problem hiding this comment.
Check the in-code comments.
Herokuapp validation TestCases :
-RedirectLink
-MouseHover
-HorizontalSlider
-FileDownloadValidation
-NotificationMessage
-AddRemoveElementsValidation
-MultipleWindows
-FileUploadValidation
-DigestAuthentication
-DisappearingElementsValidation
-ForgotPassword
-JavaScriptAlert
-BasicAuth
-DragAndDropValidation
-ContextMenuValidation
-BrokenImage
-Input
-CheckboxesValidation
-InfiniteScroll
-DropDownValidation
-ABTestingValidation
-NestedFrames
-Iframe
-ValidUserNamePassword
-InvalidUserNamePassword
-InvalidUserName
-InvalidPassword
-DynamicContentValidation
-DynamicControlsValidation