Release/v1.26.4

.github/workflows/build.yml

@@ -3,9 +3,11 @@ name: Build
 on:
   push:
     branches: [ "develop", "feature/**", "bugfix/**" ]
+    paths-ignore: [ '.mvn/**', 'mvnw', 'mvnw.cmd', '.run/**', 'docs/**', '.editorconfig', '.gitignore', '**.md' ]
   pull_request:
     branches: [ "develop" ]
     types: [ opened, reopened, edited ]
+    paths-ignore: [ '.mvn/**', 'mvnw', 'mvnw.cmd', '.run/**', 'docs/**', '.editorconfig', '.gitignore', '**.md' ]
 
 jobs:
   build:
@@ -66,8 +68,8 @@ jobs:
             directives: -DmacosTests
             moduleName: it-macos
           - os: windows-latest
-            profiles: browsers
-            directives: -DbrowsersTests
+            profiles: windows
+            directives: -DwindowsTests
             moduleName: it
     runs-on: ${{ matrix.os }}
     env:

.run/spotless_apply.run.xml

@@ -0,0 +1,32 @@
+<component name="ProjectRunConfigurationManager">
+  <configuration default="false" name="spotless:apply" type="MavenRunConfiguration" factoryName="Maven">
+    <MavenSettings>
+      <option name="myGeneralSettings" />
+      <option name="myRunnerSettings" />
+      <option name="myRunnerParameters">
+        <MavenRunnerParameters>
+          <option name="cmdOptions" />
+          <option name="profiles">
+            <set />
+          </option>
+          <option name="goals">
+            <list>
+              <option value="spotless:apply" />
+            </list>
+          </option>
+          <option name="multimoduleDir" />
+          <option name="pomFileName" />
+          <option name="profilesMap">
+            <map />
+          </option>
+          <option name="projectsCmdOptionValues">
+            <list />
+          </option>
+          <option name="resolveToWorkspace" value="false" />
+          <option name="workingDirPath" value="$PROJECT_DIR$" />
+        </MavenRunnerParameters>
+      </option>
+    </MavenSettings>
+    <method v="2" />
+  </configuration>
+</component>

DEV.md

@@ -13,10 +13,12 @@ client would. So, we build the framework in a dedicated module, and then we incl
 | [it-bidi](it-bidi)                 | Runs a bunch of tests with the `webSocketUrl` capability                      |
 | [it-testbook](it-testbook)         | Runs a bunch of tests with a testbook                                         |
 | [it-macos](it-macos)               | Runs a bunch of tests specific to macOS (Safari)                              |
+| [it-windows](it-windows)           | Runs a bunch of tests on Windows (useful for GH actions to reduce flakiness)  |
 | [it-appium](it-appium)             | Runs a bunch of tests with Appium                                             |
 | [verify-commons](verify-commons)   | Contains common classes used in other verify modules                          |
 | [verify-browsers](verify-browsers) | Verifies results of the `it`, `it-testbook`, `it-grid`, and `it-bidi` modules |
 | [verify-macos](verify-macos)       | Verifies results of the `it-macos` module                                     |
+| [verify-windows](verify-windows)   | Verifies results of the `it-windows` module                                   |
 | [verify-appium](verify-appium)     | Verifies results of the `it-appium` module                                    |
 | [cleanup](cleanup)                 | Cleans each module after the execution                                        |
 
@@ -79,8 +81,10 @@ Where:
   on [Maven Central](https://central.sonatype.com/artifact/io.github.giulong/spectrum).
 * the `-DbrowsersTests` property is a shorthand to activate all the profiles needed to run tests on all the browsers. It's equivalent to
   running with these active profiles: `-P chrome,firefox,edge`.
-* the `-DmacosTests` property is a shorthand to activate all the profiles needed to run tests on macOS. It's equivalent to
+* the `-DmacosTests` property is a shorthand to activate all the profiles needed to run tests specific to Safari. It's equivalent to
   running with these active profiles: `-P safari`.
+* the `-DwindowsTests` property is a shorthand to activate all the profiles needed to run tests on Windows in GitHub build action. It's equivalent to
+  running with these active profiles: `-P windows`. NOTE: this is not needed in local: it's meant to just run fewer tests on windows workers in CI builds.
 * the `-DappiumTests` property is a shorthand to activate all the profiles needed to run tests on Appium. It's equivalent to
   running with these active profiles: `-P uiAutomator2`.
 * the `-fae` option is [Maven's](https://maven.apache.org/ref/3.6.3/maven-embedder/cli.html) shorthand for `--fail-at-end`, needed to always run the `cleanup` module.

README.md

@@ -11,7 +11,7 @@
 [![GitHub Discussions](https://img.shields.io/github/discussions/giulong/spectrum)](https://github.com/giulong/spectrum/discussions)
 
 <br />
-<img src="src/main/resources/images/spectrum-logo.png" alt="Spectrum logo">
+<img src="docs/assets/images/spectrum-logo.png" alt="Spectrum logo">
 
 <br/>
 <br/>
@@ -74,14 +74,14 @@ https://github.com/giulong/spectrum/assets/27963644/fecee8f5-f6dc-4b47-81a3-514e
 > `-Dspectrum.driver=firefox`, `-Dspectrum.driver=edge` or `-Dspectrum.driver=safari`
 
 Here's an overview of the project created by the archetype, along with the generated report and video:<br/><br/>
-<img style="width: 49%; vertical-align: top;" src="src/main/resources/images/login-form-it.png" alt="login-form"/>
-&nbsp;<img style="width: 49%; vertical-align: top;" src="src/main/resources/images/login-form-it-extent-report.png" alt="report"/>
+<img style="width: 49%; vertical-align: top;" src="docs/assets/images/login-form-it.png" alt="login-form"/>
+&nbsp;<img style="width: 49%; vertical-align: top;" src="docs/assets/images/login-form-it-extent-report.png" alt="report"/>
 
 https://github.com/giulong/spectrum/assets/27963644/df6b801e-91ca-415b-b510-a45b7392de20
 
 You can also configure Spectrum to produce additional reports, such as summary and coverage:<br/><br/>
-<img style="width: 49%; vertical-align: top;" src="src/main/resources/images/html-summary.png" alt="summary"/>
-&nbsp;<img style="width: 49%; vertical-align: top;" src="src/main/resources/images/html-testbook.png" alt="html testbook"/>
+<img style="width: 49%; vertical-align: top;" src="docs/assets/images/readme-html-summary.png" alt="summary"/>
+&nbsp;<img style="width: 49%; vertical-align: top;" src="docs/assets/images/readme-html-testbook.png" alt="html testbook"/>
 
 If you like Spectrum, please consider giving it a GitHub Star ⭐
 

cleanup/pom.xml

@@ -18,14 +18,6 @@
 
     <build>
         <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-checkstyle-plugin</artifactId>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-compiler-plugin</artifactId>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-resources-plugin</artifactId>
@@ -138,6 +130,42 @@
                             </resources>
                         </configuration>
                     </execution>
+                    <execution>
+                        <id>Copy LauncherSessionListener to "it-windows" module's classes</id>
+                        <phase>clean</phase>
+                        <goals>
+                            <goal>copy-resources</goal>
+                        </goals>
+                        <configuration>
+                            <outputDirectory>../it-windows/target/classes/META-INF/services</outputDirectory>
+                            <resources>
+                                <resource>
+                                    <directory>${spectrumMetaInfServicesFolder}</directory>
+                                    <includes>
+                                        <include>${launcherSessionListener}</include>
+                                    </includes>
+                                </resource>
+                            </resources>
+                        </configuration>
+                    </execution>
+                    <execution>
+                        <id>Copy LauncherSessionListener to "verify-windows" module's classes</id>
+                        <phase>clean</phase>
+                        <goals>
+                            <goal>copy-resources</goal>
+                        </goals>
+                        <configuration>
+                            <outputDirectory>../verify-windows/target/classes/META-INF/services</outputDirectory>
+                            <resources>
+                                <resource>
+                                    <directory>${spectrumMetaInfServicesFolder}</directory>
+                                    <includes>
+                                        <include>${launcherSessionListener}</include>
+                                    </includes>
+                                </resource>
+                            </resources>
+                        </configuration>
+                    </execution>
                     <execution>
                         <id>Copy LauncherSessionListener to "it-appium" module's classes</id>
                         <phase>clean</phase>

it-appium/pom.xml

@@ -39,6 +39,10 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>com.diffplug.spotless</groupId>
+                <artifactId>spotless-maven-plugin</artifactId>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>
@@ -86,4 +90,4 @@
             </build>
         </profile>
     </profiles>
-</project>
+</project>

it-bidi/pom.xml

@@ -39,6 +39,10 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>com.diffplug.spotless</groupId>
+                <artifactId>spotless-maven-plugin</artifactId>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>

it-grid/pom.xml

@@ -48,6 +48,10 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>com.diffplug.spotless</groupId>
+                <artifactId>spotless-maven-plugin</artifactId>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>

it-grid/src/test/java/io/github/giulong/spectrum/it_grid/tests/FilesIT.java

@@ -2,16 +2,21 @@
 
 import static java.nio.charset.StandardCharsets.UTF_8;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.openqa.selenium.support.ui.ExpectedConditions.visibilityOf;
 
 import java.io.IOException;
 import java.io.OutputStream;
 import java.net.HttpURLConnection;
 import java.net.URI;
 import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Scanner;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
@@ -50,6 +55,10 @@ void download() {
         downloadPage.getDownloadLinks().getFirst().click();
 
         assertThrows(TimeoutException.class, () -> checkDownloadedFile(FILE_TO_DOWNLOAD));
+
+        final Path downloadsFolder = Path.of(String.valueOf(configuration.getVars().get("downloadsFolder")));
+        assertTrue(Files.exists(downloadsFolder));
+        assertNotEquals(0, Objects.requireNonNull(downloadsFolder.toFile().listFiles()).length);
     }
 
     @Test

it-macos/pom.xml

@@ -39,6 +39,10 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>com.diffplug.spotless</groupId>
+                <artifactId>spotless-maven-plugin</artifactId>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>

it-testbook/pom.xml

@@ -39,6 +39,10 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
             </plugin>
+            <plugin>
+                <groupId>com.diffplug.spotless</groupId>
+                <artifactId>spotless-maven-plugin</artifactId>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>

it-testbook/src/test/java/io/github/giulong/spectrum/it_testbook/TestBookSessionListener.java

@@ -176,23 +176,23 @@ public void launcherSessionClosed(LauncherSession session) {
     private void createExtentFiles(final List<String> fileNames, final Path directory) {
         for (String fileName : fileNames) {
             assertTrue(Files.createFile(directory.resolve(fileUtils.removeExtensionFrom(fileName)).resolve(fileName)).toFile().exists());
-            Thread.sleep(1000);   // just to be sure files have different creation dates
+            Thread.sleep(1000); // just to be sure files have different creation dates
         }
     }
 
     @SneakyThrows
     private void createFiles(final List<String> fileNames, final Path directory) {
         for (String fileName : fileNames) {
             assertTrue(Files.createFile(directory.resolve(fileName)).toFile().exists());
-            Thread.sleep(1000);   // just to be sure files have different creation dates
+            Thread.sleep(1000); // just to be sure files have different creation dates
         }
     }
 
     @SneakyThrows
     private void createDirectories(final List<String> directoryNames, final Path parentDirectory) {
         for (String fileName : directoryNames) {
             assertTrue(Files.createDirectories(parentDirectory.resolve(fileName)).toFile().exists());
-            Thread.sleep(1000);   // just to be sure files have different creation dates
+            Thread.sleep(1000); // just to be sure files have different creation dates
         }
     }
 

it-testbook/src/test/java/io/github/giulong/spectrum/it_testbook/tests/FilesIT.java

@@ -1,9 +1,15 @@
 package io.github.giulong.spectrum.it_testbook.tests;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.openqa.selenium.support.ui.ExpectedConditions.visibilityOf;
 
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Objects;
+
 import io.github.giulong.spectrum.SpectrumTest;
 import io.github.giulong.spectrum.it_testbook.pages.DownloadPage;
 import io.github.giulong.spectrum.it_testbook.pages.UploadPage;
@@ -33,6 +39,10 @@ void download() {
         downloadPage.getDownloadLinks().getFirst().click();
 
         assertThrows(TimeoutException.class, () -> checkDownloadedFile(FILE_TO_DOWNLOAD));
+
+        final Path downloadsFolder = Path.of(String.valueOf(configuration.getVars().get("downloadsFolder")));
+        assertTrue(Files.exists(downloadsFolder));
+        assertNotEquals(0, Objects.requireNonNull(downloadsFolder.toFile().listFiles()).length);
     }
 
     @Test

it-testbook/src/test/java/io/github/giulong/spectrum/it_testbook/tests/LoginFormIT.java

@@ -51,7 +51,6 @@ void shouldRunSuccessfully(final String userName, final boolean expected, final
     static Stream<Arguments> valuesProvider() {
         return Stream.of(
                 arguments("tom", true, "/secure"),
-                arguments("giulio", false, "/login")
-        );
+                arguments("giulio", false, "/login"));
     }
 }