V2.8.1.1

Readme.md

@@ -244,9 +244,13 @@ can be really useful in visualising the issue along with any files you consider
 
 Version Information
 ===================
- 5th December 2014 Version 2.8.1.1
-  1.  New 'Show section summary when collapsed' feture gratefully funded by 'Te Rito Maioha Early Childhood New Zealand - https://ecnz.ac.nz'.
+11th December 2014 Version 2.8.1.1
+  1.  New 'Show section summary when collapsed' feature gratefully funded by 'Te Rito Maioha Early Childhood New Zealand - https://ecnz.ac.nz'.
   2.  Fix CONTRIB-5472.
+  3.  Integrated 'Use core required_param for toggle parameters.': https://github.com/gjb2048/moodle-format_topcoll/pull/12
+      "This work was made possible through funding from Te Rito Maioha Early Childhood New Zealand".
+      Improves on work instigated in CONTRIB-5211 and related to MDL-46754.
+  4.  Improved HTTP protocol handling in 'settopcollpref.php'.
 
 16th November 2014 Version 2.8.1
   1.  Stable version for Moodle 2.8.

settopcollpref.php

@@ -46,8 +46,12 @@
 // Get and set the value.
 $value = required_topcoll_param('value');
 // Update
-if (!set_user_preference($name, $value)) {
-    print_error('errorsettinguserpref');
+if ($value) {
+    if (!set_user_preference($name, $value)) {
+        print_error('errorsettinguserpref');
+    }
+    echo 'OK';
+} else {
+    header('HTTP/1.1 406 Not Acceptable');
+    echo 'Not Acceptable';
 }
-
-echo 'OK';

togglelib.php

@@ -260,7 +260,7 @@ function clean_topcoll_param($param) {
     for ($i = 0; $i < $chars; $i++) {
         $charval = ord($param[$i]);
         if (($charval < 58) || ($charval > 121)) {
-            return '';
+            return false;
         }
     }
     return $param;

version.php

@@ -34,7 +34,7 @@
  */
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version = 2014120300;
+$plugin->version = 2014121100;
 $plugin->maturity = MATURITY_STABLE;
 $plugin->requires = 2014111000.00; // 2.8 (Build: 20141110).
 $plugin->component = 'format_topcoll';