Ignore positions recalc #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Jun 13, 2017
package.json
Outdated
| "color-id": "^1.0.0", | ||
| "font-atlas-sdf": "^1.2.0", | ||
| "color-id": "^1.1.0", | ||
| "font-atlas-sdf": "^1.3.1", |
There was a problem hiding this comment.
Judging from
https://github.com/dfcreative/font-atlas-sdf/commits/master
this should be ^1.3.2, right?
|
@dfcreative looking good! All tests are passing off this branch. Moreover, I've played around with lasso/select off plotly/plotly.js#1657 and the improvements are noticeable (maybe @monfera could confirm if he has the time 😄 ) Let's leave this PR open until plotly/plotly.js#1657 is Thanks! |
9 tasks
etpinard
added a commit
to plotly/plotly.js
that referenced
this pull request
Jun 14, 2017
includes PRs: - #1657 - gl-vis/gl-scatter2d-sdf#5 - #1781 - #1770
|
All right, I couldn't find any broken behavior off this branch 🎉 @dfcreative can you merge and publish this thing? |
|
@etpinard done! |
|
Beautiful. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up updating positions for plotly/plotly.js#1657 (comment)