fix: reset s:is_wsl after calling (un)install #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudyang1
force-pushed
the
fix/reset_wsl_state
branch
2 times, most recently
from
33e9d73
to
2703425
Compare
glacambre
reviewed
Jul 29, 2024
The behaviors of `firenvim#install` and `firenvim#uninstall` on WSL is controlled by the script variable `s:is_wsl`: we initialize it to false to (un)install firenvim on wsl side, and then set it to 1 to (un)install on windows host side. Currently, only `firenvim#install` and `firenvim#uninstall` changes the value of `s:is_wsl`. The two function do not reset `s:is_wsl`, and thus `s:is_wsl` is always 1 after calling them. As a result, doing the followings sequentially in neovim have unexpected results: ```lua -- 1. `s:is_wsl` is set to 1 vim.fn["firenvim#install"](0) -- 2. uninstall firenvim only on windows host because `s:is_wsl` is 1 vim.fn["firenvim#uninstall"]() ``` ```lua -- 1. `s:is_wsl` is set to 1 vim.fn["firenvim#uninstall"]() -- 2. reinstall, installs scripts on host only, no scripts on WSL vim.fn["firenvim#install"](0) ``` To fix this, a `try ... finally` block resets `s:is_wsl` even if the two functions throw errors or run unsuccessfully.
xudyang1
force-pushed
the
fix/reset_wsl_state
branch
from
2703425
to
b0c92d4
Compare
|
Thanks! Sorry for the late merge - I'm a bit distracted. |
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviors of
firenvim#installandfirenvim#uninstallon WSL are controlled by the script variables:is_wsl: we initialize it to false to (un)install firenvim on wsl side, and then set it to 1 to (un)install on windows host side.Currently, only
firenvim#installandfirenvim#uninstallchanges the value ofs:is_wsl. The two function do not resets:is_wsl, and thuss:is_wslis always 1 after calling them.As a result, doing the followings sequentially in neovim have unexpected results:
To fix this, a
try ... finallyblock resetss:is_wsleven if the two functions throw errors or run unsuccessfully.