Skip to content

Commit

Permalink
Disable bundlesize for now
Browse files Browse the repository at this point in the history
  • Loading branch information
kmjennison committed Nov 5, 2023
1 parent f879566 commit c6978f5
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 501 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ jobs:
run: yarn test # generates coverage
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v2
- name: Check bundle sizes
run: yarn run bundlesize:no-build
env:
BUNDLESIZE_GITHUB_TOKEN: ${{ secrets.BUNDLESIZE_GITHUB_TOKEN }}
# Disabling bundlesize for now because of:
# https://github.com/siddharthkp/bundlesize/pull/370
# - name: Check bundle sizes
# run: yarn run bundlesize:no-build
# env:
# BUNDLESIZE_GITHUB_TOKEN: ${{ secrets.BUNDLESIZE_GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"lint": "tsc --noEmit && eslint ./",
"bundlesize": "npm-run-all -s build bundlesize:no-build",
"bundlesize:no-build": "bundlesize",
"bundlesize:comment": "Uninstalled bundlesize for now because of https://github.com/siddharthkp/bundlesize/pull/370",
"test": "npm-run-all -s install-example-deps lint test:coverage",
"test:run": "jest --env=jsdom",
"test:coverage": "yarn run test:run --coverage",
Expand Down Expand Up @@ -60,7 +61,6 @@
"babel-jest": "^29.6.1",
"babel-loader": "^9.1.3",
"babel-plugin-module-resolver": "^5.0.0",
"bundlesize": "^0.18.1",
"copy-webpack-plugin": "^11.0.0",
"core-js": "^3.31.1",
"datwd": "^0.2.0",
Expand Down
Loading

0 comments on commit c6978f5

Please sign in to comment.