gh-273: add tests for glass.shells
#449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
added
enhancement
This makes them available to all tests. I need `cosmo` for use in #449. Have also added `scope="session"` so they are only computed once when testing rather than multiple times.
Saransh-cpp
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Thanks, @paddyroddy! I have made some comments about using assert instead of np.testing functions on non-array values. I am not sure if there was a reason to use np.testing for these test case; ignore my comments if there was one.
I guess this is a habit of mine since I learnt about |
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
|
Sorry for the late reply. I guess it was just the extra function call overheads, but not a big deal, both of the implementations look good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #273. Adds tests for the
glass.shellsmodule. Coverage going up - 94.1%.Worked on this before the pause. Can't remember where I got to, but makes sense to merge. We can always improve the tests later.