gh-468: fix virtualenv in testing #471
Conversation
paddyroddy
changed the title
| @@ -7,8 +7,12 @@ | |||
| import nox | |||
|
|
|||
| # Options to modify nox behaviour | |||
| nox.options.default_venv_backend = "uv|virtualenv" | |||
There was a problem hiding this comment.
Fixed my issues locally using uv astral-sh/uv#6579
There was a problem hiding this comment.
I remember we could not use uv because of astral-sh/uv#1794
I am surprised that it is working now. We still use the --prefer-binary flag in our tests -
glass/.github/test-constraints.txt
Line 10 in f6cfde4
There was a problem hiding this comment.
But locally I'm not. With my uv environments locally it was failing without this. I'm not using the test-constraints.txt file.
.github/workflows/test.yml
Outdated
| - name: Install ubuntu dependencies for fitsio | ||
| run: |- | ||
| sudo apt-get update | ||
| sudo apt-get install -y libbz2-dev |
There was a problem hiding this comment.
| @@ -38,7 +38,7 @@ jobs: | |||
| - name: Cache nox | |||
| uses: actions/cache@v4 | |||
| with: | |||
| key: test-${{ hashFiles('pyproject.toml') }} | |||
| key: test-${{ hashFiles('pyproject.toml') }}-${{ env.pythonLocation }} | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This is weird. I have never encountered this bug before.
There was a problem hiding this comment.
Thanks for digging into this, @paddyroddy! See my comments below -
| @@ -38,7 +38,7 @@ jobs: | |||
| - name: Cache nox | |||
| uses: actions/cache@v4 | |||
| with: | |||
| key: test-${{ hashFiles('pyproject.toml') }} | |||
| key: test-${{ hashFiles('pyproject.toml') }}-${{ env.pythonLocation }} | |||
There was a problem hiding this comment.
This is weird. I have never encountered this bug before.
glass/core/array.py
Outdated
| @@ -166,7 +166,7 @@ def trapezoid_product( | |||
| y = np.interp(x, *f) | |||
| for f_ in ff: | |||
| y *= np.interp(x, *f_) | |||
| return np.atleast_1d(np.trapezoid(y, x, axis=axis)) | |||
| return np.trapezoid(y, x, axis=axis) # type: ignore[no-any-return] | |||
There was a problem hiding this comment.
Should the mypy fixes be another PR?
There was a problem hiding this comment.
I hadn't asked for a review... The PR was open to get the tests running. I've merged in #484.
| @@ -7,8 +7,12 @@ | |||
| import nox | |||
|
|
|||
| # Options to modify nox behaviour | |||
| nox.options.default_venv_backend = "uv|virtualenv" | |||
There was a problem hiding this comment.
I remember we could not use uv because of astral-sh/uv#1794
I am surprised that it is working now. We still use the --prefer-binary flag in our tests -
glass/.github/test-constraints.txt
Line 10 in f6cfde4
|
Merging this, linting still failing. |
Fixes #468, #479. The problem initially why the tests were failing was esheldon/fitsio#413 esheldon/fitsio#414. I have solved this by reinstating #396.
However, the tests were failing (just for
3.11) for a very nichenoxbug wntrblm/nox#735. I'm still not particularly happy withnox, the ecosystem seems immature. I considered switching totox#475, as I haven't had those issues before. However, this proved a bit tricky as I didn't want to change too much how we currently our running things, and we're relying on a fair bit of Python logic. In the end, this comment wntrblm/nox#735 (comment) referred to about modifying the cache and that seems to have solved the issue.