Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 + Crawl Params for Tanakai #2

Closed
wants to merge 16 commits into from

Conversation

jkeen
Copy link

@jkeen jkeen commented Nov 7, 2022

  1. Allow passing data: {} into crawl! from this @dtengeri branch https://github.com/dtengeri/kimuraframework
  2. Ruby 3 compatibility from this @n-studio branch: https://github.com/n-studio/kimuraframework
  3. Combined PR that remains stagnant on the @vifreefly repo: Updates From The Active Fork: Ruby 3 Support, Bug Fixes, New Drivers (Cuprite, Apparition), Test Updates vifreefly/kimuraframework#70

This PR is that combined work plus dealing with some merge conflicts

@drougojrom
Copy link

hey!
thank you for all your effort, but just a small question then, do you have any plans of merging and releasing this update?

@jkeen
Copy link
Author

jkeen commented Jun 23, 2023

If only it were up to me!

This part of the open source community is really frustrating, because I can submit PRs all day long but maintainers have to push the buttons to merge and release. The number of PRs I have just sitting out there not being paid attention to… I try not to think about it.

@glaucocustodio
Copy link
Owner

Sorry @jkeen, I missed this going on. Tanakai already got support to ruby 3, could you please open separate PR's for the other things and I will be happy to merge and cut a new version. Thanks.

@glaucocustodio glaucocustodio force-pushed the master branch 4 times, most recently from 9d60c43 to 23a59af Compare October 25, 2023 18:32
@glaucocustodio
Copy link
Owner

Closing this as Tanakai already supports Ruby 3 and passing data to crawl! as well (the latter since version 1.7.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants