-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 3 + Crawl Params for Tanakai #2
Conversation
…ed some development gems Fixed Ruby 2.7 warning for keyword arguments
adbbd2c
to
2ae72c9
Compare
2ae72c9
to
0becb7f
Compare
hey! |
If only it were up to me! This part of the open source community is really frustrating, because I can submit PRs all day long but maintainers have to push the buttons to merge and release. The number of PRs I have just sitting out there not being paid attention to… I try not to think about it. |
Sorry @jkeen, I missed this going on. Tanakai already got support to ruby 3, could you please open separate PR's for the other things and I will be happy to merge and cut a new version. Thanks. |
9d60c43
to
23a59af
Compare
Closing this as Tanakai already supports Ruby 3 and passing |
This PR is that combined work plus dealing with some merge conflicts