fix issue with windows local manifest paths being absolute #2842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2837
The issue was that on Windows canonicalise adds a special root prefix https://stackoverflow.com/questions/41233684/why-does-my-canonicalized-path-get-prefixed-with which caused the diff to not properly work when creating the relative path. Since keeping the target canonical might be important for resolutions in some cases this pr updates the source to be canonicalized when doing the relative path.
I tested this against https://github.com/Acepie/p5js_gleam locally on my windows computer and it seems to work as expected now.