Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check for exposing multiple modules on publish #3838

Merged
merged 1 commit into from
Dec 2, 2024
Merged

feat: check for exposing multiple modules on publish #3838

merged 1 commit into from
Dec 2, 2024

Conversation

Guria
Copy link
Contributor

@Guria Guria commented Nov 16, 2024 •
edited
Loading

fixes #3834

reusing existing --yes flag to bypass new warning.

@Guria
Copy link
Contributor Author

Guria commented Nov 22, 2024

rebased to solve conflict in ci workflow file

lpil
lpil reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you! Couple small things inline

test/multi_namespace/src/foo.gleam Outdated Show resolved Hide resolved
compiler-cli/src/publish.rs Show resolved Hide resolved
@Guria
Copy link
Contributor Author

Guria commented Nov 27, 2024 •
edited
Loading

@lpil updated

Should I also use recently added cli::confirm_with_text method for this check as well?

lpil
lpil reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really nice! Left one comment inline

compiler-cli/src/publish.rs Outdated Show resolved Hide resolved
@Guria
Copy link
Contributor Author

Guria commented Nov 28, 2024 •
edited
Loading

@lpil updated

lpil
lpil approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@lpil lpil enabled auto-merge (rebase) December 2, 2024 17:15
@lpil lpil merged commit 639b4f6 into gleam-lang:main Dec 2, 2024
12 checks passed
@Guria Guria deleted the fix-3834 branch December 2, 2024 18:32
@Guria
Copy link
Contributor Author

Guria commented Dec 2, 2024

@lpil looks like we miss changelog entry for this one

@lpil
Copy link
Member

lpil commented Dec 2, 2024

Oh dang, sorry I missed that. Could you add one please 🙏

@Guria
Copy link
Contributor Author

Guria commented Dec 2, 2024

@lpil #3940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate package with multiple top level module names on publish
2 participants
@Guria @lpil