Add canonical link #3872
Add canonical link #3872
Conversation
rockerBOO
force-pushed
the
canonical-link
branch
from
0e0eeb0 to
8bde60f
Compare
| between multiple versions of the same package. --> | ||
| <script src="./docs_config.js"></script> | ||
| <link id="syntax-theme" rel="stylesheet" href="./css/atom-one-light.min.css?v=GLEAM_VERSION_HERE"/> | ||
| <link rel="canconical" href="./test_canconical/app.html" /> |
There was a problem hiding this comment.
Canonical URLs need to be absolute!
There was a problem hiding this comment.
How do we know the absolute URL here? Since users could host it themselves; I am not aware of where this setting is.
There was a problem hiding this comment.
It should be set via configuration when publishing to Hex. We can omit otherwise for now
| @@ -18,6 +18,7 @@ expression: "compile_with_markdown_pages(config, vec![], pages)" | |||
| between multiple versions of the same package. --> | |||
| <script src="./docs_config.js"></script> | |||
| <link id="syntax-theme" rel="stylesheet" href="./css/atom-one-light.min.css?v=GLEAM_VERSION_HERE"/> | |||
|
|
|||
There was a problem hiding this comment.
Could you configure all the tests to have them please 🙏
There was a problem hiding this comment.
These are not displayed because the project_name is blank
There was a problem hiding this comment.
Yes! I'm asking you to add it to all of them 🙏 Thank you.
A test case for rendering not-for-hex would also be great.
| {% if !host.is_empty() && !project_name.is_empty() -%} | ||
| <link rel="canonical" href="{{ host }}/{{ project_name|safe }}/{{ file_path|safe }}" /> | ||
| {%- endif %} | ||
| {%- endblock %} |
There was a problem hiding this comment.
Is there a reason not to have this in the layout? It seems to be the same for both templates.
There was a problem hiding this comment.
Originally was more direct to put it where I knew it was being used, but has converged enough that I now have moved it directly into the layout.
| @@ -18,6 +18,7 @@ expression: "compile_with_markdown_pages(config, vec![], pages)" | |||
| between multiple versions of the same package. --> | |||
| <script src="./docs_config.js"></script> | |||
| <link id="syntax-theme" rel="stylesheet" href="./css/atom-one-light.min.css?v=GLEAM_VERSION_HERE"/> | |||
|
|
|||
There was a problem hiding this comment.
Yes! I'm asking you to add it to all of them 🙏 Thank you.
A test case for rendering not-for-hex would also be great.
<head>There are snapshots as well but wanted to get this committed and reviewed.
Fixes #3864
Thanks.