-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better help texts for Error::ShellProgramNotFound #4082
Conversation
add bun, deno, elixir and split the matching logic into different OS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thank you! Could you add snapshot tests for the new functionality please 🙏
hi there, I wrote a new snapshot test in best regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! I've left a few small notes inline and then we're ready to go!
compiler-core/src/error/snapshots/gleam_core__error__tests__bun-linux-ubuntu.snap
Outdated
Show resolved
Hide resolved
Hi there, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! A few small notes inline
6aa4cda
to
17eaab0
Compare
Hi, I re-constructed the code :) Now And I split the get_distro to only acquire the Best regards |
I wrote standalone tests for extracting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! Just a couple more tiny tweaks, and if you could add an empty line between the package manager suggestion and the docs link that'd be fab. Ideally the docs link would be the last thing in the message.
...e/src/error/snapshots/gleam_core__error__tests__shell_program_not_found_bun_macos_other.snap
Outdated
Show resolved
Hide resolved
.../src/error/snapshots/gleam_core__error__tests__shell_program_not_found_deno_macos_other.snap
Outdated
Show resolved
Hide resolved
...c/error/snapshots/gleam_core__error__tests__shell_program_not_found_elixir_linux_ubuntu.snap
Outdated
Show resolved
Hide resolved
OK 🦊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bravo!! Thank you so much!
add bun, deno, elixir and nodejs installation helper texts and improved per OS instructions