-
Notifications
You must be signed in to change notification settings - Fork 29
Fixing nested timeout contexts using both thread and signal based Timeout contexts #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixing nested timeout contexts using both thread and signal based Timeout contexts #37
Conversation
|
@mmatera I started fixing issues with this repo here: https://github.com/spraakbanken/stopit2 I am interested of including this PR (I recreated it here: spraakbanken#5 including adapting code to my changes of the project) |
Hi, @kod-kristoff. Sorry for the delay in the answer. I am glad to know that you are working on update this project. This is how we are using it: and works in ubuntu, windows and osx. What is not working is in "emscripten", a platform for which it would be nice to port it too. |
This PR would provide a more complete fix for #17, handling timeouts with both kinds of Timeout context managers.