Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slower performance when creating batches with many entries #37

Open
youhavethewrong opened this issue Oct 29, 2022 · 0 comments
Open

Slower performance when creating batches with many entries #37

youhavethewrong opened this issue Oct 29, 2022 · 0 comments

Comments

@youhavethewrong
Copy link

I've noticed that file generation slows down significantly when adding many entries into the same batch. I've created a pull request with a suggestion of removing the updating of batch counts and totals on every addEntry() call and instead doing it when the user wants with a new updateBatchValues() method. This way, those who have a use case to update the counts and totals after every addEntry() call can still do so, while those who only need those totals updated at the time of generateFile() can realize much better performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant