Create new method on Batch granting control over count/sum updates. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, performance when adding many entries to the same batch could become quite poor, and some users only need batches counts and totals up to date at the time of rendering the NACHA file. With this new method, users who need constant batch counts and totals updated can still call updateBatchValues() after every addEntry() and those who don't can enjoy much improved file generation time.
|
This PR resolves #37 |
hartalex
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, performance when adding many entries to the same batch could become quite poor, and some users only need batches counts and totals up to date at the time of rendering the NACHA file. With this new method, users who need constant batch counts and totals updated can still call updateBatchValues() after every addEntry() and those who don't can enjoy much improved file generation time.