Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nedbank k6 load test #6436

Merged
merged 15 commits into from
Feb 7, 2025
Merged

Add Nedbank k6 load test #6436

merged 15 commits into from
Feb 7, 2025

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Jan 29, 2025

AB#32228

Describe your changes

Adds K6 load test for Nedbank integration, includes:

  • Nedbank reset
  • Nedbank cronJob patch endpoint
  • Additional initializePayment method for Nedbank

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@Piotrk39 Piotrk39 added enhancement New feature or request that affects our end users chore Something that does not affect the end user labels Jan 29, 2025
@Piotrk39 Piotrk39 changed the base branch from main to feat.nedbank January 29, 2025 11:48
@RubenGeo RubenGeo force-pushed the feat.nedbank branch 4 times, most recently from 968bcbe to a5665ac Compare February 5, 2025 14:44
@Piotrk39 Piotrk39 force-pushed the test.-add-nedbank-k6-test branch from e8e2d4d to bf77b45 Compare February 6, 2025 10:53
@Piotrk39 Piotrk39 force-pushed the test.-add-nedbank-k6-test branch from b8b2df3 to c24f05d Compare February 6, 2025 12:11
@Piotrk39 Piotrk39 marked this pull request as ready for review February 6, 2025 12:27
Copy link
Contributor

@RubenGeo RubenGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just some minor thing!

Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
@Piotrk39
Copy link
Contributor Author

Piotrk39 commented Feb 6, 2025

@RubenGeo one left console log was actually left on purpose it is there to log the incoming error. I committed the rest. Thanks!

@RubenGeo RubenGeo merged commit ebc9bfc into feat.nedbank Feb 7, 2025
5 checks passed
@RubenGeo RubenGeo deleted the test.-add-nedbank-k6-test branch February 7, 2025 08:17
diderikvw pushed a commit that referenced this pull request Feb 7, 2025
* Nedbank implementation

* Moved nedbank entity and change error message

* Add data attributes and nedbank cronjob endpoint

* Change order of cron job

* Add comments and finish first stage

* Add validation and refactor payment functions

* lower duplicate numbers for test

* Update PA multipliers

* Add fixes

* remove unused files

* Update k6/helpers/registration-default.data.js

Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>

* Update k6/models/programs.js

Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>

* Update k6/tests/payment100kRegistrationNedbank.js

Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>

* Update k6/tests/retryFailedJobsOnStartupDuringQueueProcessing.js

Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>

* Fix missing error response log

---------

Co-authored-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
RubenGeo added a commit that referenced this pull request Feb 7, 2025
* Nedbank implementation

* Moved nedbank entity and change error message

* Add data attributes and nedbank cronjob endpoint

* Change order of cron job

* Add comments and finish first stage

* Add validation and refactor payment functions

* lower duplicate numbers for test

* Update PA multipliers

* Add fixes

* remove unused files

* Update k6/helpers/registration-default.data.js

Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>

* Update k6/models/programs.js

Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>

* Update k6/tests/payment100kRegistrationNedbank.js

Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>

* Update k6/tests/retryFailedJobsOnStartupDuringQueueProcessing.js

Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>

* Fix missing error response log

---------

Co-authored-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user enhancement New feature or request that affects our end users
Development

Successfully merging this pull request may close these issues.

2 participants