-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nedbank k6 load test #6436
Merged
Merged
Add Nedbank k6 load test #6436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
968bcbe
to
a5665ac
Compare
e8e2d4d
to
bf77b45
Compare
b8b2df3
to
c24f05d
Compare
RubenGeo
requested changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just some minor thing!
Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
@RubenGeo one left console log was actually left on purpose it is there to log the incoming error. I committed the rest. Thanks! |
RubenGeo
approved these changes
Feb 7, 2025
diderikvw
pushed a commit
that referenced
this pull request
Feb 7, 2025
* Nedbank implementation * Moved nedbank entity and change error message * Add data attributes and nedbank cronjob endpoint * Change order of cron job * Add comments and finish first stage * Add validation and refactor payment functions * lower duplicate numbers for test * Update PA multipliers * Add fixes * remove unused files * Update k6/helpers/registration-default.data.js Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com> * Update k6/models/programs.js Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com> * Update k6/tests/payment100kRegistrationNedbank.js Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com> * Update k6/tests/retryFailedJobsOnStartupDuringQueueProcessing.js Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com> * Fix missing error response log --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
RubenGeo
added a commit
that referenced
this pull request
Feb 7, 2025
* Nedbank implementation * Moved nedbank entity and change error message * Add data attributes and nedbank cronjob endpoint * Change order of cron job * Add comments and finish first stage * Add validation and refactor payment functions * lower duplicate numbers for test * Update PA multipliers * Add fixes * remove unused files * Update k6/helpers/registration-default.data.js Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com> * Update k6/models/programs.js Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com> * Update k6/tests/payment100kRegistrationNedbank.js Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com> * Update k6/tests/retryFailedJobsOnStartupDuringQueueProcessing.js Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com> * Fix missing error response log --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: RubenGeo <34537157+RubenGeo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Something that does not affect the end user
enhancement
New feature or request that affects our end users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#32228
Describe your changes
Adds K6 load test for Nedbank integration, includes:
Checklist before requesting a review
Portalicious preview deployment
This PR does not have any preview deployments yet.