Duplicates backend & integration tests #6521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 18 changed files in this pull request and generated 2 comments.
Files not reviewed (13)
- services/121-service/src/scripts/sql/mock-introduce-duplicates.sql: Language not supported
- services/121-service/swagger.json: Language not supported
- services/121-service/src/registration/validators/registrations-input-validator.ts: Evaluated as low risk
- services/121-service/src/scripts/seed-multiple-nlrc-mock.ts: Evaluated as low risk
- services/121-service/src/registration/const/filter-operation.const.ts: Evaluated as low risk
- services/121-service/src/registration/interfaces/get-duplicates-result.interface.ts: Evaluated as low risk
- services/121-service/src/registration/services/registrations-pagination.service.ts: Evaluated as low risk
- services/121-service/test/helpers/registration.helper.ts: Evaluated as low risk
- services/121-service/src/registration/registration-view.entity.ts: Evaluated as low risk
- services/121-service/src/registration/registrations.service.ts: Evaluated as low risk
- services/121-service/src/scripts/seed-mock-helpers.ts: Evaluated as low risk
- services/121-service/src/registration/repositories/registration-scoped.repository.ts: Evaluated as low risk
- services/121-service/src/registration/registrations.controller.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)
services/121-service/src/registration/dto/duplicate.dto.ts:3
- Resolve or remove the TODO comment about naming conventions.
// TODO: Discuss should this be name DuplicateReponseDto? (as in the guidelines) And that the api returns DuplicateReponseDto[]?
services/121-service/test/registrations/duplicates/get-duplicates.test.ts:109
- [nitpick] The test description is unclear. It should be rephrased for better readability.
it(`should not return isDuplicateAccessibleWithinScope is false and no name for a duplicate if the duplicate registration is out of the scope of the user`, async () => {
services/121-service/src/registration/enum/duplicate-status.enum.ts
Outdated
Show resolved
Hide resolved
RubenGeo
commented
Feb 14, 2025
| @ApiProperty({ example: ['phoneNumber'] }) | ||
| public readonly attributeNames: string[]; | ||
|
|
||
| @ApiProperty({ example: 'true' }) |
There was a problem hiding this comment.
I added this to help the frontend with this frame
RubenGeo
commented
Feb 14, 2025
| @@ -0,0 +1,23 @@ | |||
| import { ApiProperty } from '@nestjs/swagger'; | |||
|
|
|||
| // TODO: Discuss should this be name DuplicateReponseDto? (as in the guidelines) And that the api returns DuplicateReponseDto[]? | |||
There was a problem hiding this comment.
An array of response seems weird. It's sort of one response which can have an arrays of duplicates
RubenGeo
commented
Feb 14, 2025
| @@ -0,0 +1,222 @@ | |||
| import { RegistrationStatusEnum } from '@121-service/src/registration/enum/registration-status.enum'; | |||
There was a problem hiding this comment.
I did not add any unit tests. The reason for this is 90 % of logic is in the queries. And therefore the scenario's I could think of are all covered in integration tests. Do you see opportunities for unit testing @diderikvw
RubenGeo
force-pushed
the
feat.duplicates
branch
from
dd32980 to
fcd69b2
Compare
RubenGeo
force-pushed
the
feat.duplicates
branch
from
fcd69b2 to
ea2f8e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#33530 AB#33533 AB#33540
This PR adds:
Describe your changes
Checklist before requesting a review
I do not think it's wise to merge this before we have k6 tests
Portalicious preview deployment
This PR does not have any preview deployments yet.