Simplify double-negative constructions in check

Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
globus · Aug 6, 2023 · ce90eb8 · ce90eb8
1 parent 5c180fd
commit ce90eb8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/globus_sdk/experimental/auth_requirements_error/_variants.py b/src/globus_sdk/experimental/auth_requirements_error/_variants.py
@@ -193,9 +193,9 @@ def __init__(
         self.extra_fields = extra or {}
 
         # Enforce that the error contains at least one of the fields we expect
-        if not any(
-            (getattr(self, field_name) is not None)
-            for field_name in self.SUPPORTED_FIELDS.keys()
+        if all(
+            getattr(self, field_name) is None
+            for field_name in self.SUPPORTED_FIELDS
         ):
             raise ValueError(
                 "Must include at least one supported authorization parameter: "

diff --git a/src/globus_sdk/experimental/auth_requirements_error/auth_requirements_error.py b/src/globus_sdk/experimental/auth_requirements_error/auth_requirements_error.py
@@ -78,9 +78,9 @@ def __init__(
         self.extra_fields = extra or {}
 
         # Enforce that the error contains at least one of the fields we expect
-        if not any(
-            (getattr(self, field_name) is not None)
-            for field_name in self.SUPPORTED_FIELDS.keys()
+        if all(
+            getattr(self, field_name) is None
+            for field_name in self.SUPPORTED_FIELDS
         ):
             raise ValueError(
                 "Must include at least one supported authorization parameter: "