Support session params in oauth2_get_authorize_url #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit support for a set of known parameters to the oauth2_get_authorize_url method. These are all some flavor of string, uuid, or list thereof, and are therefore converted to comma separated lists by the SDK. The parameter descriptions are kept very brief for now, to avoid any misleading statements about what these parameters do. A test case is established for these options, building a subset of the full parameter matrix (which produced hundreds of unnecessary tests).
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
kurtmckee
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit support for a set of known parameters to the oauth2_get_authorize_url method. These are all some flavor of string, uuid, or list thereof, and are therefore converted to comma separated lists by the SDK.
The parameter descriptions are kept very brief for now, to avoid any misleading statements about what these parameters do.
A test case is established for these options, building a subset of the full parameter matrix (which produced hundreds of unnecessary tests).
📚 Documentation preview 📚: https://globus-sdk-python--773.org.readthedocs.build/en/773/