Updates #812
Closed
Updates #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using the same (default) python for all of the
requirements files in `requirements/*.in`, specify it more strictly
by making each supported python version map out to a set of
requirements files.
The mapping is that for any `requirements/foo.in`, we produce
`requirements/py{major}.{minor}/foo.txt` for all python versions we
support. `major.minor` aligns with the `{py_dot_ver}` available under
`tox`, making it trivially easy to then refer to these built
requirements from `tox.ini`.
There is one tweak to pin back the version of `pip` under py3.7 in
order to support an older pip-tools version.
kurtmckee
added
the
no-news-is-good-news
kurtmckee
requested review from
aaschaer,
ada-globus,
derek-globus and
sirosen
as code owners
|
Closing, as I didn't realize I was pushing to @sirosen's repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains changes I recommend.
📚 Documentation preview 📚: https://globus-sdk-python--812.org.readthedocs.build/en/812/