🏎️ Speed up uploading by parallelizing uploads #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickiegang
approved these changes
Mar 31, 2024
hwknsj
approved these changes
Sep 8, 2024
hwknsj
left a comment
hwknsj
left a comment
There was a problem hiding this comment.
looks good to me, i would love to see this implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is quite the right transposition of this code because it introduces some
unwrapsthat weren't there before, however massively speeds up upload speeds by submitting all uploads in parallel and then joining on all of them, making it easy to hit full 1 Gbps speeds.I think in the recursive upload case of large folders there are other optimizations that can be done to this routine (e.g. scan the filesystem first, then batch create all the folders on gdrive, then batch upload all files together) but I didn't quite get around to that.
For me this was one-off throw-away code tbh, so I'll likely won't be updating this PR, feel free to close if it's too much of a burden to take on these changes.