Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employ short circuit logic in group.include.all. #36

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

joaander
Copy link
Member

Description

Stop evaluating group.include.all conditions after the first false.

Motivation and context

Allow more flexible use of conditions in workspaces. I have a workspace where all directories have a /subproject value - but not all have a /pressure. The following condition is well-defined as long as all patchy_particle_pressure directories do have /pressure.

[[action.group.include]]
all = [
    [
    '/subproject',
    '==',
    'patchy_particle_pressure',
],
    [
    '/pressure',
    '>',
    0,
],

How has this been tested?

Tested locally with hoomd-validation.

Checklist:

  • I have reviewed the Contributor Guidelines.
  • I agree with the terms of the Row Contributor Agreement.
  • My name is on the list of contributors (doc/src/contributors.md) in the pull request source branch.
  • I have added a change log entry to doc/src/release-notes.md.

@joaander joaander requested a review from tcmoore3 August 20, 2024 12:13
@joaander joaander merged commit ecaafaf into trunk Aug 21, 2024
17 checks passed
@joaander joaander deleted the short-circuit-all branch August 21, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant